-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](jvm)fix jvm metrics memory leak. #44311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](jvm)fix jvm metrics memory leak. #44311
Conversation
### What problem does this PR solve? fix jvm metrics memory leak.before pr apache#42507 when you set `enable_jvm_monitor=true` in be.conf, you can find that be jvm memory is slowly growing. By analyzing the hprof file, we can find that there are a large number of `java.lang.management.ThreadInfo` objects. The specific cause of the memory leak is: jni does not manually delete the local reference after getting the object from the array, resulting in the object not being GC.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 45171 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 32.15 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
### What problem does this PR solve? Issue Number: close #xxx Related PR: #42507 Problem Summary: fix jvm metrics memory leak. when you set `enable_jvm_monitor=true` in be.conf, you can find that be jvm memory is slowly growing. By analyzing the hprof file, we can find that there are a large number of `java.lang.management.ThreadInfo` objects. The specific cause of the memory leak is: jni does not manually delete the local reference after getting the object from the array, resulting in the object not being GC.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #42507
Problem Summary:
fix jvm metrics memory leak.
when you set
enable_jvm_monitor=truein be.conf, you can find that be jvm memory is slowly growing.By analyzing the hprof file, we can find that there are a large number of
java.lang.management.ThreadInfoobjects.The specific cause of the memory leak is: jni does not manually delete the local reference after getting the object from the array, resulting in the object not being GC.
Release note
None
Check List (For Author)
Test
just fix memory leak no logic has been changed
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)