Skip to content

[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setting #44362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Nov 21, 2024
Merged

[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setting #44362

dataroaring merged 1 commit into from
Nov 21, 2024

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Nov 20, 2024

What problem does this PR solve?

Related PR: #42413

Problem Summary:

UT failed with coredump in PR #42413 but was not detected by CI. Fix the problem.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Nov 20, 2024

run buildall

gavinchou
gavinchou previously approved these changes Nov 20, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Hastyshell Hastyshell dismissed stale reviews from dataroaring and gavinchou via 6e17d80 November 20, 2024 16:28
@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Nov 20, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Nov 20, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Nov 20, 2024

run cloudut

@gavinchou
Copy link
Contributor

gavinchou commented Nov 20, 2024

run cloud_ut

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2024

PR approved by at least one committer and no changes requested.

@gavinchou
Copy link
Contributor

gavinchou commented Nov 21, 2024

run cloud_p0

hello-stephen
hello-stephen approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 012620c into apache:master Nov 21, 2024
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
@Hastyshell
[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setti…
63cd07d 
…ng (#44362)

UT failed with coredump in PR #42413 but was not detected by CI. Fix the
problem.
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 21, 2024
@github-actions @Hastyshell
branch-3.0: [Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate…
9cd1287 
… limit setting #44362 (#44370)

Cherry-picked from #44362

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hastyshell @doris-robot @gavinchou @hello-stephen @dataroaring