[ODBC SCAN NODE] 4/4 Add ODBC_SCAN_NODE and Odbc_Scanner in BE and add ODBC_SCAN_NODE docs #4438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d odbc external table doc.
wutiangan
reviewed
Aug 24, 2020
be/src/exec/odbc_scan_node.cpp
Outdated
| } | ||
|
|
||
| // Before we fix the problem utf8 encode sql query in SQLexecDirect | ||
| // we need to check some filter can not encode in asii code, like chinese |
be/src/exec/odbc_scan_node.cpp
Outdated
| } | ||
|
|
||
| _tuple = reinterpret_cast<Tuple*>(tuple_buffer); | ||
| // Indicates whether there are more rows to process. Set in _hbase_scanner.next(). |
be/src/exec/odbc_scanner.cpp
Outdated
|
|
||
| LOG(INFO) << "execute success:" << query << " column count:" << _field_num; | ||
|
|
||
| // check materialize num equeal _field_num |
| return Status::InternalError(msg.str()); | ||
| } | ||
|
|
||
| std::string ODBCScanner::handle_diagnostic_record(SQLHANDLE hHandle, |
| | DOUBLE | DOUBLE | | | ||
| | DATE | DATE | | | ||
| | DECIMAL | DECIMAL | | | ||
|
|
Contributor
There was a problem hiding this comment.
hll data type?
datetime data type?
Contributor
Author
There was a problem hiding this comment.
mysql now do not support hll, i will add datetime type in doc
|
|
||
| 4. 通过Oracle访问出现乱码 | ||
|
|
||
| 尝试在BE启动脚本之中添加如下参数：`export NLS_LANG=AMERICAN_AMERICA.AL32UTF8`， 并重新启动所有BE |
Contributor
There was a problem hiding this comment.
这个参数如果直接放到be的启动脚本里会有啥影响？
Contributor
Author
There was a problem hiding this comment.
不会有什么影响，但是原则上不使用oracle数据库的话是用不到这个环境变量的
be/src/exec/odbc_scanner.cpp
Outdated
| ODBC_DISPOSE(_dbc, SQL_HANDLE_DBC, SQLDriverConnect(_dbc, NULL, (SQLCHAR*)_connect_string.c_str(), SQL_NTS, | ||
| NULL, 0, NULL, SQL_DRIVER_COMPLETE_REQUIRED), "driver connect"); | ||
|
|
||
| LOG(INFO) << "connect success:"; |
Contributor
There was a problem hiding this comment.
add more detail informaton in log
morningman
added
the
kind/feature
morningman
reviewed
Sep 22, 2020
be/src/exec/odbc_scan_node.h
Outdated
| // converting text data in MySQL cells to binary data. | ||
| virtual Status get_next(RuntimeState* state, RowBatch* row_batch, bool* eos); | ||
|
|
||
| // Close the _mysql_scanner, and report errors. |
be/src/exec/odbc_scanner.cpp
Outdated
| // Now we only treat HLL, CHAR, VARCHAR as big column | ||
| static constexpr uint32_t BIG_COLUMN_SIZE_BUFFER = 65535; | ||
|
|
||
| static std::u16string utf8_to_wstring (const std::string& str) |
Contributor
There was a problem hiding this comment.
Suggested change
| static std::u16string utf8_to_wstring (const std::string& str) | |
| static std::u16string utf8_to_wstring(const std::string& str) |
| #### 2. 通过ODBC_Resource来创建ODBC外表 (推荐使用的方式) | ||
| ``` | ||
| create external resource "oracle_odbc" | ||
| properties |
caoyang10
pushed a commit
to caoyang10/incubator-doris
that referenced
this pull request
Oct 29, 2020
…d ODBC_SCAN_NODE docs (apache#4438)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4376 issue
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.