-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Persistence stale rowsets meta #4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ZhangYu0123 Hi, What's the concrete issue that this PR want to Fix? what's the accurate definition for |
|
70b8593 to
ae44041
Compare
I see. Thanks. |
| Version stale_meta_version = stale_meta->version(); | ||
| add_version(stale_meta_version); | ||
| // 2.4 find the path | ||
| if (r) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get this logic...
| Version stale_meta_version = stale_meta->version(); | ||
| add_version(stale_meta_version); | ||
| // 2.4 find the path | ||
| if (r) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get this logic...
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @kangkaisen , I think |
Proposed changes
Persistence stale rowsets meta. When be reboots, stale rowsets meta can resume and the stale version can also be readable before stale gc time.
ISSUE: #4453
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.