Skip to content

[fix](Nereids) move tables from connect context to statement context #44568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 4 commits into from
Dec 3, 2024
Merged

[fix](Nereids) move tables from connect context to statement context #44568

morrySnow merged 4 commits into from
Dec 3, 2024

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Nov 25, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
When using tables in connect context, it would keep on memory in next run in the same session, but it should not be in memory when running next sql statement

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 25, 2024

run buildall

1 similar comment
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 26, 2024

run buildall

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 26, 2024

run p0

1 similar comment
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 26, 2024

run p0

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Nov 27, 2024

run buildall

morrySnow
morrySnow previously approved these changes Nov 28, 2024
View reviewed changes
@morrySnow morrySnow requested a review from 924060929 November 28, 2024 15:08
@LiBinfeng-01 LiBinfeng-01 force-pushed the fix_tables_in_connectcontext branch from 66e7c45 to e361ebc Compare December 2, 2024 12:11
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Dec 2, 2024

run buildall

@morrySnow
Copy link
Contributor

morrySnow commented Dec 3, 2024

run feut

morrySnow
morrySnow previously approved these changes Dec 3, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Dec 3, 2024

run buildall

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Dec 3, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 80c2b8d into apache:master Dec 3, 2024
15 of 16 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
[fix](Nereids) move tables from connect context to statement context (#…
9cab960 
…44568)

Problem Summary:
When using tables in connect context, it would keep on memory in next
run in the same session, but it should not be in memory when running
next sql statement
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
LiBinfeng-01 pushed a commit to LiBinfeng-01/doris that referenced this pull request Dec 10, 2024
[fix](Nereids) move tables from connect context to statement context (a…
20a6f4c 
…pache#44568)

Problem Summary:
When using tables in connect context, it would keep on memory in next
run in the same session, but it should not be in memory when running
next sql statement
@LiBinfeng-01 LiBinfeng-01 mentioned this pull request Dec 10, 2024
Closed
16 tasks
yiguolei pushed a commit to LiBinfeng-01/doris that referenced this pull request Dec 18, 2024
@yiguolei
[fix](Nereids) move tables from connect context to statement context (a…
107f779 
…pache#44568)

Problem Summary:
When using tables in connect context, it would keep on memory in next
run in the same session, but it should not be in memory when running
next sql statement
morrySnow pushed a commit that referenced this pull request Dec 19, 2024
@github-actions
branch-3.0: [fix](Nereids) move tables from connect context to statem…
12982ab 
…ent context #44568 (#44957)

Cherry-picked from #44568

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LiBinfeng-01 @doris-robot @morrySnow @924060929