[Refactor] Refactor storage medium migration task process #4475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
force-pushed
the
migration_task
branch
2 times, most recently
from
caed1bc to
ef22bf1
Compare
morningman
force-pushed
the
migration_task
branch
from
ef22bf1 to
f000d5e
Compare
morningman
force-pushed
the
migration_task
branch
from
f000d5e to
a765b0b
Compare
EmmyMiao87
reviewed
Oct 21, 2020
| TabletSharedPtr tablet; | ||
| DataDir* dest_store; | ||
| if (_check_migrate_requset(storage_medium_migrate_req, tablet, &dest_store) != OLAP_SUCCESS) { | ||
| status_code = TStatusCode::RUNTIME_ERROR; |
Contributor
There was a problem hiding this comment.
Doesn't it print out the reason for the check failure?
5 tasks
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
…fferent disks (apache#5101) Based on PR apache#4475, this patch add a new feature for single tablet migration between different disks by http. Co-authored-by: weizuo <weizuo@xiaomi.com>
levy5307
pushed a commit
to levy5307/incubator-doris
that referenced
this pull request
Nov 14, 2022
…fferent disks (apache#5101) Based on PR apache#4475, this patch add a new feature for single tablet migration between different disks by http. Co-authored-by: weizuo <weizuo@xiaomi.com>
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Sep 23, 2025
…e. (apache#4475) Co-authored-by: daidai <changyuwei@selectdb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This CL refactor the storage medium migration task process in BE.
I did not modify the execution logic. Just extract part of the logic
in the migration task and put it in
task_work_pool.In this way, the migration task is only used to process the migration
from the specified tablet to the specified data dir.
Later, we can use this task to migrate of tablets between different disks. #4476
Types of changes
Checklist