Skip to content

Conversation

@Hastyshell
Copy link
Collaborator

What problem does this PR solve?

Rowset meta may exceed limit of 2GB incase of table of extremely wide variant type. Check the size before serializing.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell Hastyshell marked this pull request as ready for review November 29, 2024 09:07
@Hastyshell Hastyshell force-pushed the fix-rowset-meta-too-big branch from 001b254 to ad0bedd Compare November 29, 2024 09:10
@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell Hastyshell requested a review from gavinchou December 5, 2024 12:42
@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 8c5307e into apache:master Dec 9, 2024
15 of 16 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
…atal (#44780)

Rowset meta may exceed limit of 2GB incase of table of extremely wide
variant type. Check the size before serializing.
dataroaring pushed a commit that referenced this pull request Dec 9, 2024
…n protobuf fatal #44780 (#45205)

Cherry-picked from #44780

Co-authored-by: Siyang Tang <tangsiyang2001@foxmail.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants