Do not add exchange when table's distributioin satisfy the distribution requirements #4482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on requirements For apache#4481. In DistributedPlanner, do not add the unnecessary Exchanges. For case 1, we only need to judge that the table's distribute hash keys is a subset of the aggregate keys. For case 2, we should jude two conditions: - partition keys are also hash keys. - the table's distribute hash keys is a subset of the aggregate keys.
kangkaisen
reviewed
Aug 30, 2020
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
Outdated
Show resolved
Hide resolved
kangkaisen
reviewed
Aug 30, 2020
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
Outdated
Show resolved
Hide resolved
kangkaisen
reviewed
Aug 30, 2020
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
kangkaisen
added
approved
ZhangYu0123
pushed a commit
to ZhangYu0123/incubator-doris
that referenced
this pull request
Sep 1, 2020
…on requirements (apache#4482) In DistributedPlanner, do not add the unnecessary Exchanges. For case 1, we only need to judge that the table's distribute hash keys is a subset of the aggregate keys. For case 2, we should judge two conditions: - partition keys are also hash keys. - the table's distribute hash keys is a subset of the aggregate keys.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4481.
Proposed changes
In DistributedPlanner, do not add the unnecessary Exchanges.
For case 1, we only need to judge that the table's distribute hash keys is a subset of the aggregate keys.
For case 2, we should jude two conditions: