Skip to content

[fix](recycler) fix idx file leak in recycler #44908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 2 commits into from
Dec 4, 2024
Merged

[fix](recycler) fix idx file leak in recycler #44908

airborne12 merged 2 commits into from
Dec 4, 2024

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented Dec 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #38306

Problem Summary:
Non inverted index storage format for old version will cause leaking recycling idx files.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Dec 3, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

airborne12 commented Dec 3, 2024

run buildall

gavinchou
gavinchou reviewed Dec 3, 2024
View reviewed changes
@airborne12
Copy link
Member Author

airborne12 commented Dec 3, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 170b5d3 into apache:master Dec 4, 2024
17 of 18 checks passed
@airborne12 airborne12 deleted the fix-recycler branch December 4, 2024 02:35
github-actions bot pushed a commit that referenced this pull request Dec 4, 2024
@airborne12
[fix](recycler) fix idx file leak in recycler (#44908)
2367b5f 
Related PR: #38306

Problem Summary:
Non inverted index storage format for old version will cause leaking
recycling idx files.
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@wm1581066 wm1581066 added the p0_b label Dec 4, 2024
airborne12 added a commit that referenced this pull request Dec 4, 2024
@github-actions @airborne12
branch-3.0: [fix](recycler) fix idx file leak in recycler #44908 (#44966
12ba87a 
)

Cherry-picked from #44908

Co-authored-by: airborne12 <jiangkai@selectdb.com>
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@airborne12 @gavinchou
[fix](recycler) fix idx file leak in recycler (apache#44908)
111fa6c 
Related PR: apache#38306

Problem Summary:
Non inverted index storage format for old version will cause leaking
recycling idx files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@airborne12 @doris-robot @gavinchou @csun5285 @wm1581066