[Spark load][Bug] Fix column terminator for spark load #4491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 31, 2020 21:21
xy720
changed the title
morningman
reviewed
Sep 1, 2020
| this.fileFieldNames = fileFieldNames; | ||
| this.columnsFromPath = columnsFromPath; | ||
| this.columnSeparator = columnSeparator; | ||
| this.columnSeparator = Strings.isNullOrEmpty(columnSeparator)?'\t': columnSeparator.charAt(0); |
Contributor
There was a problem hiding this comment.
Suggested change
| this.columnSeparator = Strings.isNullOrEmpty(columnSeparator)?'\t': columnSeparator.charAt(0); | |
| this.columnSeparator = Strings.isNullOrEmpty(columnSeparator) ? '\t' : columnSeparator.charAt(0); |
| record -> { | ||
| scannedRowsAcc.add(1); | ||
| String[] attributes = record.split(fileGroup.columnSeparator); | ||
| char sep = fileGroup.columnSeparator; |
Contributor
There was a problem hiding this comment.
Make it execute only once.
added 2 commits
September 1, 2020 14:27
morningman
added
approved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix #4490
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...