Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 3, 2024

Cherry-picked from #44877

…44877)

### What problem does this PR solve?
#40697 that introduced the issue.


```
F20241202 18:56:00.498481 233860 assert_cast.h:57] Bad cast from type:doris::vectorized::ColumnVector<unsigned __int128> to doris::vectorized::ColumnVector<wide::integer<128ul, unsigned int> >
*** Check failure stack trace: ***
    @     0x562c12168fb6  google::LogMessage::SendToLog()
    @     0x562c12165a00  google::LogMessage::Flush()
    @     0x562c121697f9  google::LogMessageFatal::~LogMessageFatal()
    @     0x562c0acb66a6  _ZZ11assert_castIRN5doris10vectorized12ColumnVectorIN4wide7integerILm128EjEEEEL18TypeCheckOnRelease1ERNS1_7IColumnEET_OT1_ENKUlOSB_E_clISA_EES7_SE_
    @     0x562c0acb64e7  assert_cast<>()
    @     0x562c0acb637d  doris::vectorized::AggregateFunctionArrayAggData<>::insert_result_into()
    @     0x562c11f12282  doris::pipeline::AggLocalState::_get_results_without_key()
    @     0x562c11f3a251  std::_Function_handler<>::_M_invoke()
    @     0x562c11f13ee8  doris::pipeline::AggSourceOperatorX::get_block()
    @     0x562c1174e3cf  doris::pipeline::OperatorXBase::get_block_after_projects()
    @     0x562c120ad87b  doris::pipeline::PipelineTask::execute()
    @     0x562c120bb7b2  doris::pipeline::TaskScheduler::_do_work()
    @     0x562c081ef935  doris::ThreadPool::dispatch_thread()
    @     0x562c081e6321  doris::Thread::supervise_thread()
    @     0x7f446f9b01ca  start_thread
    @     0x7f447039fe73  __GI___clone
    @              (nil)  (unknown)
*** Query id: c24a997f61b847d2-adece222f56b3b9e ***
*** is nereids: 1 ***
*** tablet id: 0 ***
*** Aborted at 1733136960 (unix time) try "date -d @1733136960" if you are using GNU date ***
*** Current BE git commitID: 1551ef9 ***
*** SIGABRT unknown detail explain (@0x47000039002) received by PID 233474 (TID 233860 OR 0x7f436d1f2700) from PID 233474; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/yanxuecheng/doris/be/src/common/signal_handler.h:421
 1# 0x00007F44703B4B50 in /lib64/libc.so.6
 2# gsignal in /lib64/libc.so.6
 3# __GI_abort in /lib64/libc.so.6
 4# 0x0000562C1217388D in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
 5# 0x0000562C12165ECA in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
 6# google::LogMessage::SendToLog() in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
 7# google::LogMessage::Flush() in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
 8# google::LogMessageFatal::~LogMessageFatal() in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
 9# doris::vectorized::ColumnVector<wide::integer<128ul, unsigned int> >& assert_cast<doris::vectorized::ColumnVector<wide::integer<128ul, unsigned int> >&, (TypeCheckOnRelease)1, doris::vectorized::IColumn&>(doris::vectorized::IColumn&)::{lambda(auto:1&&)#1}::operator()<doris::vectorized::IColumn&>(doris::vectorized::IColumn&) const at /mnt/disk2/yanxuecheng/doris/be/src/vec/common/assert_cast.h:57
10# doris::vectorized::ColumnVector<wide::integer<128ul, unsigned int> >& assert_cast<doris::vectorized::ColumnVector<wide::integer<128ul, unsigned int> >&, (TypeCheckOnRelease)1, doris::vectorized::IColumn&>(doris::vectorized::IColumn&) at /mnt/disk2/yanxuecheng/doris/be/src/vec/common/assert_cast.h:72
11# doris::vectorized::AggregateFunctionArrayAggData<wide::integer<128ul, unsigned int> >::insert_result_into(doris::vectorized::IColumn&) const in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
12# doris::pipeline::AggLocalState::_get_results_without_key(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /mnt/disk2/yanxuecheng/doris/be/src/pipeline/exec/aggregation_source_operator.cpp:349
13# std::_Function_handler<doris::Status (doris::RuntimeState*, doris::vectorized::Block*, bool*), std::_Bind_result<doris::Status, doris::Status (doris::pipeline::AggLocalState::*(doris::pipeline::AggLocalState*, std::_Placeholder<1>, std::_Placeholder<2>, std::_Placeholder<3>))(doris::RuntimeState*, doris::vectorized::Block*, bool*)> >::_M_invoke(std::_Any_data const&, doris::RuntimeState*&&, doris::vectorized::Block*&&, bool*&&) at /mnt/disk2/yanxuecheng/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:290
14# doris::pipeline::AggSourceOperatorX::get_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /mnt/disk2/yanxuecheng/doris/be/src/pipeline/exec/aggregation_source_operator.cpp:439
15# doris::pipeline::OperatorXBase::get_block_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
16# doris::pipeline::PipelineTask::execute(bool*) at /mnt/disk2/yanxuecheng/doris/be/src/pipeline/pipeline_task.cpp:378
17# doris::pipeline::TaskScheduler::_do_work(int) at /mnt/disk2/yanxuecheng/doris/be/src/pipeline/task_scheduler.cpp:138
18# doris::ThreadPool::dispatch_thread() in /mnt/disk2/yanxuecheng/doris/output/be/lib/doris_be
19# doris::Thread::supervise_thread(void*) at /mnt/disk2/yanxuecheng/doris/be/src/util/thread.cpp:499
20# start_thread in /lib64/libpthread.so.0
21# __clone in /lib64/libc.so.6
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 3, 2024
@dataroaring dataroaring reopened this Dec 3, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40527 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 641d53d3c350cc1f3a7afe17f47d9bab3bdb3948, data reload: false

------ Round 1 ----------------------------------
q1	17577	7427	7328	7328
q2	2067	174	173	173
q3	10704	1077	1140	1077
q4	10576	805	755	755
q5	7739	2851	2812	2812
q6	233	147	146	146
q7	996	612	585	585
q8	9573	1929	1926	1926
q9	7558	6395	6414	6395
q10	6991	2285	2341	2285
q11	463	259	258	258
q12	409	224	213	213
q13	17768	2990	3019	2990
q14	234	207	207	207
q15	554	529	516	516
q16	680	602	594	594
q17	966	604	558	558
q18	7192	6430	6547	6430
q19	2116	1029	1011	1011
q20	452	209	193	193
q21	3912	3339	3090	3090
q22	1037	985	987	985
Total cold run time: 109797 ms
Total hot run time: 40527 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7365	7262	7243	7243
q2	322	233	243	233
q3	2915	2886	2888	2886
q4	1988	1847	1732	1732
q5	5671	5661	5734	5661
q6	227	149	152	149
q7	2149	1761	1755	1755
q8	3367	3533	3389	3389
q9	8868	8892	8778	8778
q10	3516	3500	3525	3500
q11	612	503	495	495
q12	843	662	608	608
q13	16430	3165	3156	3156
q14	304	275	268	268
q15	578	531	518	518
q16	735	693	670	670
q17	1851	1616	1579	1579
q18	8035	7805	7619	7619
q19	7058	1619	1571	1571
q20	2124	1878	1836	1836
q21	5371	5243	5341	5243
q22	1107	1054	997	997
Total cold run time: 81436 ms
Total hot run time: 59886 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195302 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 641d53d3c350cc1f3a7afe17f47d9bab3bdb3948, data reload: false

query1	1230	919	925	919
query2	6238	2051	2057	2051
query3	10852	4196	3916	3916
query4	65781	28276	23386	23386
query5	5636	465	452	452
query6	505	180	161	161
query7	6220	313	316	313
query8	323	213	211	211
query9	9647	2666	2671	2666
query10	517	287	258	258
query11	18231	15345	15727	15345
query12	156	103	97	97
query13	1576	434	413	413
query14	11263	6795	7465	6795
query15	211	178	183	178
query16	7314	455	492	455
query17	1413	591	573	573
query18	1860	327	317	317
query19	217	154	165	154
query20	118	115	111	111
query21	209	105	101	101
query22	4548	4548	4626	4548
query23	34589	33963	34031	33963
query24	5985	2964	2887	2887
query25	538	415	423	415
query26	704	180	169	169
query27	1842	302	306	302
query28	4408	2567	2533	2533
query29	702	467	459	459
query30	252	165	166	165
query31	1047	834	855	834
query32	65	55	56	55
query33	446	316	286	286
query34	898	515	521	515
query35	849	722	738	722
query36	1080	950	946	946
query37	117	66	70	66
query38	4102	3951	4066	3951
query39	1551	1468	1501	1468
query40	216	104	100	100
query41	50	47	46	46
query42	110	101	107	101
query43	550	505	493	493
query44	1185	826	824	824
query45	191	176	167	167
query46	1160	770	780	770
query47	2031	1892	1912	1892
query48	463	365	370	365
query49	726	376	380	376
query50	864	428	418	418
query51	7270	7124	7103	7103
query52	105	87	83	83
query53	255	184	184	184
query54	576	444	450	444
query55	72	75	72	72
query56	251	229	229	229
query57	1206	1081	1078	1078
query58	202	201	199	199
query59	3194	2788	2851	2788
query60	274	243	238	238
query61	107	106	104	104
query62	754	653	648	648
query63	202	185	199	185
query64	1729	655	609	609
query65	3226	3184	3245	3184
query66	715	286	297	286
query67	15790	15238	15350	15238
query68	4515	547	544	544
query69	421	251	260	251
query70	1205	1123	1107	1107
query71	389	248	258	248
query72	6452	3988	3867	3867
query73	756	337	339	337
query74	10228	9024	8803	8803
query75	3322	2633	2650	2633
query76	2131	1198	1077	1077
query77	466	270	270	270
query78	10775	9641	9414	9414
query79	8499	597	586	586
query80	2017	409	410	409
query81	550	246	238	238
query82	1240	111	113	111
query83	288	138	139	138
query84	292	76	77	76
query85	1809	313	280	280
query86	478	296	302	296
query87	4390	4283	4264	4264
query88	5833	2360	2399	2360
query89	564	298	283	283
query90	2078	183	182	182
query91	196	139	142	139
query92	68	47	44	44
query93	6873	551	535	535
query94	876	298	293	293
query95	350	247	250	247
query96	620	281	294	281
query97	3268	3155	3119	3119
query98	225	202	195	195
query99	1617	1295	1295	1295
Total cold run time: 339505 ms
Total hot run time: 195302 ms

@dataroaring dataroaring merged commit fff936b into branch-3.0 Dec 4, 2024
11 of 12 checks passed
@github-actions github-actions bot deleted the auto-pick-44877-branch-3.0 branch December 4, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants