Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

Proposed changes

"SELECT * FROM t1 LEFT SEMI JOIN t0 ON t1.c0 = t0.c0", and "t0" is an unique key. This select clause will appear error: "Illegal column/field reference 't0.DORIS_DELETE_SIGN' of semi-/anti-join", but user don't know what is the meaning of this error, how to solve this problem. In this patch, it will tell user "DORIS_DELETE_SIGN is a hidden column to mark whether a row deleted when unique key existed, 'DORIS_DELETE_SIGN = 0' will appear in where clause, that will cause semi join syntax error, please use '[not] in/existed' as replacement."

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yangzhg
Copy link
Member

yangzhg commented Sep 1, 2020

This is a bug , if a table has delete sign column, it will throw erros when using semi/anti join.
I will fix this bug, so there is no need to modify the error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants