[Bug] function str_to_date()'s behavior on BE and FE is inconsistent #4495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
reviewed
Sep 1, 2020
| // throw InvalidFormatException if encounter errors. | ||
| // this method is exaclty same as from_date_format_str() in be/src/runtime/datetime_value.cpp | ||
| // change this method should also change that. | ||
| public int fromDateFormatStr(String format, String value, boolean hasSubVal) throws InvalidFormatException { |
Contributor
There was a problem hiding this comment.
Move these util methods to a single util class?
Contributor
Author
There was a problem hiding this comment.
It is now only used for DateLiteral, and this method is also in datetime_value.cpp in BE.
So I think we can just leave it here.
Contributor
There was a problem hiding this comment.
Ok. I think the Literal class should be simple. But which isn't a big issue.
morningman
force-pushed
the
str_to_date
branch
from
f08da98 to
e8a5db6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Main CL:
str_to_date()function in FE.str_to_date("2020-08-08", "%Y-%m-%d %H:%i:%s")will return2020-08-08 00:00:00instead of2020-08-08.Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist