[feat](test) add fe ut for bf index create table #44973

airborne12 · 2024-12-04T03:48:03Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Fix wrong gram_size 256 for ngram bf index DDL.
Enhance bloom_filter_columns empty properties prcocessing in bf index DDL.
Add FE UT for ngram and bf index DDL.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-12-04T03:48:08Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

airborne12 · 2024-12-04T03:48:57Z

run buildall

airborne12 · 2024-12-04T04:04:01Z

run buildall

doris-robot · 2024-12-04T05:16:21Z

TPC-H: Total hot run time: 40023 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dcf3a66d50b3031adbe26f1b0390bb99ac15d73a, data reload: false

------ Round 1 ----------------------------------
q1	17597	7480	7294	7294
q2	2044	182	170	170
q3	10726	1094	1216	1094
q4	10479	704	728	704
q5	7602	2719	2714	2714
q6	237	153	157	153
q7	1007	617	616	616
q8	9231	1910	1951	1910
q9	6695	6489	6517	6489
q10	7053	2306	2341	2306
q11	474	260	265	260
q12	444	227	225	225
q13	17762	3021	3068	3021
q14	237	219	215	215
q15	570	530	516	516
q16	654	580	604	580
q17	981	581	594	581
q18	7362	6765	6643	6643
q19	1347	1030	919	919
q20	476	178	181	178
q21	4030	3126	3308	3126
q22	384	319	309	309
Total cold run time: 107392 ms
Total hot run time: 40023 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7303	7238	7246	7238
q2	329	236	235	235
q3	2930	2838	2932	2838
q4	2093	1811	1893	1811
q5	5764	5723	5688	5688
q6	223	144	146	144
q7	2220	1826	1809	1809
q8	3430	3579	3473	3473
q9	8985	9071	9071	9071
q10	3597	3546	3580	3546
q11	609	508	513	508
q12	808	598	589	589
q13	9570	3295	3279	3279
q14	305	267	276	267
q15	558	533	525	525
q16	695	633	657	633
q17	1864	1645	1616	1616
q18	8428	7737	7881	7737
q19	1661	1590	1541	1541
q20	2162	1902	1884	1884
q21	5679	5501	5393	5393
q22	677	588	582	582
Total cold run time: 69890 ms
Total hot run time: 60407 ms

doris-robot · 2024-12-04T05:29:03Z

TPC-DS: Total hot run time: 197861 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dcf3a66d50b3031adbe26f1b0390bb99ac15d73a, data reload: false

query1	1264	986	958	958
query2	6235	2141	2018	2018
query3	10990	4455	4600	4455
query4	66525	35216	23836	23836
query5	4971	482	456	456
query6	330	194	189	189
query7	4931	308	299	299
query8	296	255	254	254
query9	6346	2657	2647	2647
query10	422	255	252	252
query11	15760	15536	15857	15536
query12	165	112	110	110
query13	1033	452	436	436
query14	11230	6813	7014	6813
query15	212	194	190	190
query16	7349	459	497	459
query17	1069	579	573	573
query18	1808	313	305	305
query19	200	179	153	153
query20	122	112	113	112
query21	216	113	113	113
query22	4779	4540	4664	4540
query23	34965	35080	34873	34873
query24	5547	2450	2461	2450
query25	501	402	382	382
query26	640	160	154	154
query27	2051	290	290	290
query28	4261	2489	2460	2460
query29	698	449	447	447
query30	210	160	156	156
query31	995	842	856	842
query32	72	62	63	62
query33	422	326	303	303
query34	957	507	556	507
query35	863	776	801	776
query36	1074	932	979	932
query37	123	76	76	76
query38	4485	4422	4485	4422
query39	1522	1477	1451	1451
query40	202	101	101	101
query41	44	41	43	41
query42	117	100	99	99
query43	540	502	494	494
query44	1228	877	840	840
query45	189	168	167	167
query46	1168	725	728	725
query47	2009	1919	1951	1919
query48	425	325	318	318
query49	703	402	408	402
query50	844	413	401	401
query51	7397	7224	7099	7099
query52	101	91	87	87
query53	266	179	178	178
query54	521	396	390	390
query55	78	77	75	75
query56	261	228	235	228
query57	1237	1099	1122	1099
query58	218	208	211	208
query59	3150	3007	2795	2795
query60	278	245	234	234
query61	109	102	105	102
query62	809	693	681	681
query63	222	189	194	189
query64	1348	665	650	650
query65	3331	3230	3252	3230
query66	624	293	308	293
query67	16140	15547	15414	15414
query68	3769	605	576	576
query69	434	259	256	256
query70	1198	1120	1153	1120
query71	367	257	258	257
query72	6378	4040	3839	3839
query73	770	362	361	361
query74	10086	9104	9045	9045
query75	3416	2697	2702	2697
query76	1881	1163	1235	1163
query77	566	273	270	270
query78	10512	9520	9452	9452
query79	1714	607	679	607
query80	860	425	433	425
query81	500	230	237	230
query82	1257	127	125	125
query83	172	145	144	144
query84	280	77	70	70
query85	890	295	294	294
query86	346	302	295	295
query87	4850	4585	4527	4527
query88	3936	2208	2185	2185
query89	421	311	289	289
query90	1942	191	190	190
query91	134	106	107	106
query92	65	50	49	49
query93	2266	552	549	549
query94	716	299	347	299
query95	341	248	251	248
query96	635	270	280	270
query97	2911	2735	2659	2659
query98	221	203	199	199
query99	1609	1342	1319	1319
Total cold run time: 314641 ms
Total hot run time: 197861 ms

doris-robot · 2024-12-04T05:34:31Z

ClickBench: Total hot run time: 32.45 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dcf3a66d50b3031adbe26f1b0390bb99ac15d73a, data reload: false

query1	0.03	0.04	0.04
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.43	0.42	0.42
query6	1.16	0.66	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.50	0.51
query10	0.55	0.56	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.60	0.60
query14	2.73	2.79	2.78
query15	0.91	0.84	0.84
query16	0.39	0.38	0.38
query17	1.07	1.04	1.05
query18	0.21	0.21	0.20
query19	1.84	1.88	1.95
query20	0.02	0.01	0.01
query21	15.37	0.59	0.59
query22	2.49	1.99	1.09
query23	17.32	0.93	0.79
query24	2.85	1.33	1.65
query25	0.35	0.09	0.14
query26	0.42	0.13	0.14
query27	0.04	0.05	0.04
query28	10.10	1.09	1.08
query29	12.56	3.25	3.26
query30	0.25	0.07	0.07
query31	2.85	0.38	0.38
query32	3.28	0.46	0.46
query33	3.06	2.97	3.08
query34	16.80	4.50	4.52
query35	4.54	4.56	4.54
query36	0.67	0.48	0.50
query37	0.09	0.06	0.05
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 106.21 s
Total hot run time: 32.45 s

airborne12 · 2024-12-04T10:38:28Z

run buildall

doris-robot · 2024-12-04T11:26:01Z

TPC-H: Total hot run time: 40406 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3db35ffad54f290971041e49b8057ab76a2f232a, data reload: false

------ Round 1 ----------------------------------
q1	17644	7639	7330	7330
q2	2075	179	173	173
q3	10665	1124	1187	1124
q4	10537	794	749	749
q5	7638	2730	2699	2699
q6	239	145	146	145
q7	995	638	613	613
q8	9373	1902	1934	1902
q9	6756	6502	6526	6502
q10	7009	2332	2355	2332
q11	486	276	259	259
q12	428	219	217	217
q13	17790	3038	3051	3038
q14	248	215	213	213
q15	579	538	529	529
q16	671	588	580	580
q17	985	550	549	549
q18	7246	6760	6779	6760
q19	1334	1002	1041	1002
q20	459	178	181	178
q21	4014	3196	3243	3196
q22	374	326	316	316
Total cold run time: 107545 ms
Total hot run time: 40406 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7244	7229	7219	7219
q2	331	227	227	227
q3	2920	2881	2910	2881
q4	2092	1798	1840	1798
q5	5650	5690	5655	5655
q6	222	141	141	141
q7	2247	1808	1781	1781
q8	3383	3544	3487	3487
q9	8937	9062	9044	9044
q10	3618	3557	3532	3532
q11	608	532	498	498
q12	851	608	634	608
q13	10414	3266	3265	3265
q14	305	287	269	269
q15	604	526	516	516
q16	689	622	664	622
q17	1851	1649	1617	1617
q18	8358	7705	7696	7696
q19	1660	1534	1639	1534
q20	2103	1877	1877	1877
q21	5536	5526	5554	5526
q22	645	571	578	571
Total cold run time: 70268 ms
Total hot run time: 60364 ms

doris-robot · 2024-12-04T11:38:40Z

TPC-DS: Total hot run time: 197846 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3db35ffad54f290971041e49b8057ab76a2f232a, data reload: false

query1	1501	970	960	960
query2	6225	2068	1992	1992
query3	10909	4579	4382	4382
query4	66655	29104	23677	23677
query5	4953	465	447	447
query6	421	184	187	184
query7	5540	305	299	299
query8	320	240	242	240
query9	8539	2711	2718	2711
query10	442	260	248	248
query11	17281	15375	16013	15375
query12	150	109	106	106
query13	1469	412	438	412
query14	10525	7465	7629	7465
query15	222	198	198	198
query16	7395	481	467	467
query17	1122	600	589	589
query18	1817	319	366	319
query19	190	156	156	156
query20	118	111	108	108
query21	212	106	98	98
query22	4681	4529	4475	4475
query23	34968	34500	34413	34413
query24	5596	2502	2501	2501
query25	495	383	385	383
query26	643	150	157	150
query27	1795	289	285	285
query28	4359	2495	2514	2495
query29	677	416	413	413
query30	214	152	153	152
query31	980	861	866	861
query32	74	56	56	56
query33	432	296	307	296
query34	978	512	531	512
query35	888	774	752	752
query36	1085	975	979	975
query37	121	76	73	73
query38	4443	4352	4458	4352
query39	1524	1482	1470	1470
query40	200	110	102	102
query41	45	40	41	40
query42	116	98	97	97
query43	523	494	506	494
query44	1228	824	852	824
query45	190	177	169	169
query46	1205	735	742	735
query47	1971	1901	1881	1881
query48	407	317	318	317
query49	718	395	385	385
query50	832	404	401	401
query51	7413	7189	7070	7070
query52	104	93	90	90
query53	253	181	178	178
query54	507	392	381	381
query55	85	72	75	72
query56	253	231	253	231
query57	1281	1114	1151	1114
query58	227	211	228	211
query59	3185	3004	3071	3004
query60	282	254	261	254
query61	133	152	101	101
query62	792	662	658	658
query63	206	187	192	187
query64	1357	664	651	651
query65	3280	3214	3257	3214
query66	701	298	312	298
query67	16009	15725	15627	15627
query68	3761	567	566	566
query69	429	255	254	254
query70	1181	1153	1145	1145
query71	371	247	252	247
query72	6362	4034	4060	4034
query73	772	360	365	360
query74	10082	8980	8958	8958
query75	3394	2655	2669	2655
query76	1949	1048	1114	1048
query77	481	275	269	269
query78	10507	9463	9456	9456
query79	1341	600	600	600
query80	858	427	445	427
query81	490	239	236	236
query82	1259	121	119	119
query83	248	224	139	139
query84	282	71	72	71
query85	898	295	304	295
query86	338	263	297	263
query87	4698	4511	4574	4511
query88	3592	2210	2188	2188
query89	419	297	290	290
query90	2023	186	183	183
query91	145	108	99	99
query92	64	50	51	50
query93	1574	545	541	541
query94	765	284	295	284
query95	334	246	241	241
query96	615	283	278	278
query97	2861	2697	2756	2697
query98	216	195	194	194
query99	1580	1328	1315	1315
Total cold run time: 317351 ms
Total hot run time: 197846 ms

doris-robot · 2024-12-04T11:44:10Z

ClickBench: Total hot run time: 33.44 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3db35ffad54f290971041e49b8057ab76a2f232a, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.43	0.42
query6	1.16	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.50	0.51
query10	0.56	0.57	0.58
query11	0.14	0.10	0.11
query12	0.14	0.11	0.12
query13	0.61	0.62	0.60
query14	2.81	2.74	2.88
query15	0.88	0.84	0.83
query16	0.39	0.39	0.39
query17	1.08	1.05	0.98
query18	0.22	0.21	0.20
query19	1.93	1.86	2.07
query20	0.01	0.01	0.01
query21	15.40	0.60	0.58
query22	2.67	2.56	2.18
query23	17.05	0.91	0.89
query24	2.79	1.64	1.27
query25	0.26	0.20	0.13
query26	0.53	0.14	0.14
query27	0.04	0.04	0.04
query28	10.12	1.11	1.08
query29	12.55	3.28	3.29
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.25	0.46	0.45
query33	3.08	3.03	3.05
query34	16.90	4.43	4.46
query35	4.45	4.52	4.47
query36	0.68	0.48	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.39 s
Total hot run time: 33.44 s

airborne12 · 2024-12-05T09:40:50Z

run buildall

doris-robot · 2024-12-05T10:21:16Z

TPC-H: Total hot run time: 39816 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b08962e1b0455e4666581de16ff08945e20584dc, data reload: false

------ Round 1 ----------------------------------
q1	17647	7771	7288	7288
q2	2040	183	176	176
q3	10606	1056	1158	1056
q4	10563	740	723	723
q5	7605	2708	2672	2672
q6	236	144	147	144
q7	992	614	595	595
q8	9248	1869	1938	1869
q9	6635	6595	6540	6540
q10	6994	2340	2328	2328
q11	477	266	252	252
q12	411	225	211	211
q13	17784	2972	3022	2972
q14	242	207	208	207
q15	580	536	518	518
q16	652	578	580	578
q17	981	563	570	563
q18	7178	6681	6683	6681
q19	1356	1036	959	959
q20	480	179	178	178
q21	3992	3263	3007	3007
q22	377	317	299	299
Total cold run time: 107076 ms
Total hot run time: 39816 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7243	7230	7252	7230
q2	328	233	229	229
q3	2919	2783	2983	2783
q4	2058	1808	1833	1808
q5	5655	5609	5626	5609
q6	224	140	140	140
q7	2257	1798	1785	1785
q8	3387	3571	3484	3484
q9	8928	9036	9063	9036
q10	3603	3518	3533	3518
q11	614	521	499	499
q12	808	621	609	609
q13	13674	3201	3172	3172
q14	301	271	262	262
q15	569	552	528	528
q16	694	662	641	641
q17	1844	1622	1616	1616
q18	8284	7681	7562	7562
q19	1707	1587	1463	1463
q20	2129	1892	1858	1858
q21	5634	5410	5408	5408
q22	682	553	548	548
Total cold run time: 73542 ms
Total hot run time: 59788 ms

doris-robot · 2024-12-05T10:33:50Z

TPC-DS: Total hot run time: 196285 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b08962e1b0455e4666581de16ff08945e20584dc, data reload: false

query1	1469	949	943	943
query2	6278	2039	2049	2039
query3	10924	4355	4455	4355
query4	66947	32425	23790	23790
query5	5032	463	448	448
query6	324	193	189	189
query7	4899	297	299	297
query8	294	241	243	241
query9	6355	2724	2695	2695
query10	397	237	245	237
query11	15677	15419	15988	15419
query12	161	106	104	104
query13	981	416	420	416
query14	10054	6515	6624	6515
query15	227	191	195	191
query16	7061	490	469	469
query17	1232	598	600	598
query18	1786	322	318	318
query19	221	171	166	166
query20	118	123	118	118
query21	208	107	106	106
query22	4758	4684	4670	4670
query23	34687	34062	34531	34062
query24	6000	2462	2415	2415
query25	495	392	383	383
query26	638	159	150	150
query27	2229	285	295	285
query28	4723	2500	2458	2458
query29	681	417	462	417
query30	213	155	150	150
query31	1016	865	859	859
query32	66	54	75	54
query33	434	296	286	286
query34	919	507	514	507
query35	888	736	763	736
query36	1100	955	967	955
query37	126	77	73	73
query38	4485	4283	4572	4283
query39	1514	1497	1472	1472
query40	204	118	99	99
query41	43	40	47	40
query42	109	95	96	95
query43	542	500	489	489
query44	1174	822	820	820
query45	201	168	173	168
query46	1165	728	716	716
query47	2017	1968	1909	1909
query48	430	310	323	310
query49	734	403	387	387
query50	874	387	383	383
query51	7407	7154	7050	7050
query52	94	84	90	84
query53	255	174	176	174
query54	504	395	384	384
query55	80	75	79	75
query56	275	234	226	226
query57	1280	1164	1113	1113
query58	215	201	202	201
query59	3184	3098	3080	3080
query60	275	246	238	238
query61	113	108	105	105
query62	807	677	662	662
query63	213	189	205	189
query64	1419	665	651	651
query65	3267	3184	3205	3184
query66	720	305	308	305
query67	16121	15618	15513	15513
query68	3700	592	567	567
query69	427	252	250	250
query70	1185	1148	1080	1080
query71	389	250	247	247
query72	6584	4256	3848	3848
query73	775	355	359	355
query74	9488	9019	9019	9019
query75	3403	2661	2698	2661
query76	1806	1090	1049	1049
query77	535	262	268	262
query78	10505	9512	9425	9425
query79	1249	631	592	592
query80	835	431	417	417
query81	523	254	230	230
query82	208	117	114	114
query83	169	142	147	142
query84	273	69	68	68
query85	980	302	296	296
query86	351	293	299	293
query87	4734	4525	4532	4525
query88	4081	2202	2192	2192
query89	414	307	293	293
query90	2144	184	183	183
query91	141	102	106	102
query92	60	49	48	48
query93	2307	549	545	545
query94	848	295	302	295
query95	344	257	247	247
query96	621	287	274	274
query97	2854	2708	2659	2659
query98	213	185	194	185
query99	1552	1303	1309	1303
Total cold run time: 313037 ms
Total hot run time: 196285 ms

doris-robot · 2024-12-05T10:39:19Z

ClickBench: Total hot run time: 32.89 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b08962e1b0455e4666581de16ff08945e20584dc, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.64	0.10	0.11
query5	0.43	0.42	0.41
query6	1.15	0.67	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.60	0.50	0.53
query10	0.56	0.56	0.59
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.61	0.61
query14	2.71	2.74	2.69
query15	0.91	0.82	0.83
query16	0.37	0.38	0.39
query17	1.08	1.05	1.07
query18	0.21	0.21	0.20
query19	1.92	1.85	1.98
query20	0.01	0.01	0.01
query21	15.37	0.60	0.59
query22	2.39	1.98	2.06
query23	16.92	1.12	0.77
query24	3.17	1.89	1.14
query25	0.23	0.27	0.13
query26	0.56	0.15	0.13
query27	0.04	0.05	0.04
query28	10.08	1.09	1.08
query29	12.52	3.22	3.21
query30	0.26	0.07	0.07
query31	2.88	0.38	0.38
query32	3.30	0.46	0.46
query33	2.96	3.11	3.04
query34	17.02	4.51	4.45
query35	4.48	4.44	4.54
query36	0.67	0.47	0.49
query37	0.09	0.05	0.06
query38	0.04	0.03	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.14
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.22 s
Total hot run time: 32.89 s

eldenmoon

LGTM

github-actions · 2024-12-06T03:15:19Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-12-06T03:15:21Z

PR approved by anyone and no changes requested.

csun5285 · 2024-12-06T03:30:46Z

fe/fe-core/src/main/java/org/apache/doris/analysis/IndexDef.java

-                    throw new AnalysisException("invalid ngram properties:" + e.getMessage(), e);
-                }
+
+                parseAndValidateProperty(properties, NGRAM_SIZE_KEY, MIN_NGRAM_SIZE, MAX_NGRAM_SIZE);


need to modify IndexDefinition.java

qidaye

LGTM

Problem Summary: 1. Fix wrong gram_size 256 for ngram bf index DDL. 2. Enhance bloom_filter_columns empty properties prcocessing in bf index DDL. 3. Add FE UT for ngram and bf index DDL.

…45116) Cherry-picked from #44973 Co-authored-by: airborne12 <jiangkai@selectdb.com>

…tion check (#45780) Related PR: #44973 Problem Summary: Need to check ngram bf index properties in index definition for nereids.

…tion check (apache#45780) Related PR: apache#44973 Problem Summary: Need to check ngram bf index properties in index definition for nereids.

Problem Summary: 1. Fix wrong gram_size 256 for ngram bf index DDL. 2. Enhance bloom_filter_columns empty properties prcocessing in bf index DDL. 3. Add FE UT for ngram and bf index DDL.

…tion check (apache#45780) Related PR: apache#44973 Problem Summary: Need to check ngram bf index properties in index definition for nereids.

Problem Summary: 1. Fix wrong gram_size 256 for ngram bf index DDL. 2. Enhance bloom_filter_columns empty properties prcocessing in bf index DDL. 3. Add FE UT for ngram and bf index DDL.

[feat](test) add fe ut for bf index create table

db937e7

[feat](test) add fe ut for bf index create table

dcf3a66

[feat](test) add fe ut for bf index create table

3db35ff

airborne12 added 2 commits December 5, 2024 16:53

[feat](test) add fe ut for bf index create table

5e1d207

[feat](test) add fe ut for bf index create table

b08962e

eldenmoon approved these changes Dec 6, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024

github-actions bot added the reviewed label Dec 6, 2024

eldenmoon added dev/2.1.x dev/3.0.x labels Dec 6, 2024

csun5285 suggested changes Dec 6, 2024

View reviewed changes

qidaye approved these changes Dec 6, 2024

View reviewed changes

airborne12 merged commit 1f45e7f into apache:master Dec 6, 2024
19 of 20 checks passed

airborne12 deleted the add-fe-ut-for-bf branch December 6, 2024 08:13

github-actions bot mentioned this pull request Dec 6, 2024

branch-3.0: [feat](test) add fe ut for bf index create table #44973 #45116

Merged

github-actions bot mentioned this pull request Dec 6, 2024

branch-2.1: [feat](test) add fe ut for bf index create table #44973 #45117

Closed

airborne12 added a commit that referenced this pull request Dec 9, 2024

branch-3.0: [feat](test) add fe ut for bf index create table #44973 (#…

079db93

…45116) Cherry-picked from #44973 Co-authored-by: airborne12 <jiangkai@selectdb.com>

airborne12 added dev/3.0.4-merged and removed dev/2.1.x dev/3.0.x labels Dec 9, 2024

airborne12 mentioned this pull request Dec 23, 2024

[fix](bf index) add ngram bf index validation in nereids index definition check #45780

Merged

16 tasks

airborne12 added a commit that referenced this pull request Dec 31, 2024

[fix](bf index) add ngram bf index validation in nereids index defini…

8781666

…tion check (#45780) Related PR: #44973 Problem Summary: Need to check ngram bf index properties in index definition for nereids.

[feat](test) add fe ut for bf index create table #44973

[feat](test) add fe ut for bf index create table #44973

Uh oh!

Conversation

airborne12 commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

airborne12 commented Dec 4, 2024

Uh oh!

airborne12 commented Dec 4, 2024

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

airborne12 commented Dec 4, 2024

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

doris-robot commented Dec 4, 2024

Uh oh!

airborne12 commented Dec 5, 2024

Uh oh!

doris-robot commented Dec 5, 2024

Uh oh!

doris-robot commented Dec 5, 2024

Uh oh!

doris-robot commented Dec 5, 2024

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 6, 2024

Uh oh!

github-actions bot commented Dec 6, 2024

Uh oh!

csun5285 Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

qidaye left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

airborne12 commented Dec 4, 2024 •

edited

Loading