Skip to content

[feature](backup) Backup and restore cooldown data #44993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justfortaste wants to merge 2 commits into from
Closed

[feature](backup) Backup and restore cooldown data #44993

justfortaste wants to merge 2 commits into from

Conversation

@justfortaste
Copy link
Contributor

@justfortaste justfortaste commented Dec 4, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Currently, backup/resore is not supported for cooldown data.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Dec 4, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 5, 2024

run buildall

1 similar comment
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 7, 2024

run buildall

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from 441bc6a to 533fb86 Compare December 8, 2024 03:38
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 8, 2024

run buildall

1 similar comment
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 9, 2024

run buildall

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from 312972e to 2ffb009 Compare December 11, 2024 09:58
github-actions[bot]
github-actions bot reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from c3dae6b to 011c0bb Compare December 11, 2024 14:01
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 11, 2024

run buildall

2 similar comments
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 12, 2024

run buildall

@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 12, 2024

run buildall

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from 7ccc192 to d77a8ae Compare December 12, 2024 08:28
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 12, 2024

run buildall

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from 0599d45 to 7b95884 Compare December 13, 2024 08:08
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 13, 2024

run buildall

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from 7b95884 to 74105c2 Compare December 24, 2024 15:33
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 24, 2024

run buildall

@justfortaste justfortaste force-pushed the backup_cooldown_data_21 branch from dbc49ab to 74105c2 Compare December 25, 2024 03:35
@justfortaste
Copy link
Contributor Author

justfortaste commented Dec 25, 2024

run buildall

@yiguolei
Copy link
Contributor

yiguolei commented Dec 30, 2024

Do not pick this to 2.1, features should be tested in master branch and then pick to 2.1 branch because 2.1 is stable now. We should only pick bugfix to 2.1

@yiguolei yiguolei closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

not-merge/2.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justfortaste @doris-robot @yiguolei