-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Feature]Support SELECT Optimizer Hints SET_VAR #4504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A good job |
|
Hi @Astralidea |
I have updated the document, you can see if there is any need to change. |
|
@Astralidea Good job!. Please add a UT. |
好的。UT我之前看了一下,貌似不太好加,我得想想怎么加。 |
或许可以把你的逻辑加到SelectStmt 的 analyze 方法里面,这样 SelectStmtTest 就可以直接测试,确认session 变量是否生效。 不过需要注意 context.getSessionVariable().toThrift() 要在 SelectStmt.analyze(analyzer) 之后,你可以试下。 |
我改写一下DorisAssert框架可以测了。 |
kangkaisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Proposed changes
详细背景介绍在 Fix #4503
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
代码可能写得不优雅,看看怎么去解决这个问题比较好。