Skip to content

[feat](clone) Speed clone tablet via batch small file downloading #45061 #45218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Feb 10, 2025
Merged

[feat](clone) Speed clone tablet via batch small file downloading #45061 #45218

dataroaring merged 2 commits into from
Feb 10, 2025

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Dec 10, 2024

cherry pick from #45061

@w41ter
Copy link
Contributor Author

w41ter commented Dec 10, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 10, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Dec 10, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/http/http_channel.cpp

#include "http/http_channel.h"

#include <event2/buffer.h>
Copy link
Contributor

@github-actions github-actions bot Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'event2/buffer.h' file not found [clang-diagnostic-error]

#include <event2/buffer.h>
         ^

@dataroaring
Copy link
Contributor

dataroaring commented Dec 10, 2024

run buildall

@dataroaring dataroaring force-pushed the pick_45061_to_origin_branch-2.1 branch from 8dab349 to 52d8d36 Compare January 26, 2025 00:55
@dataroaring dataroaring reopened this Jan 27, 2025
@dataroaring
Copy link
Contributor

dataroaring commented Jan 27, 2025

run buildall

@w41ter w41ter force-pushed the pick_45061_to_origin_branch-2.1 branch from 52d8d36 to 0da59eb Compare February 7, 2025 03:48
@w41ter
Copy link
Contributor Author

w41ter commented Feb 7, 2025

run buildall

1 similar comment
@w41ter
Copy link
Contributor Author

w41ter commented Feb 7, 2025

run buildall

@w41ter w41ter force-pushed the pick_45061_to_origin_branch-2.1 branch from 0da59eb to b4d4d72 Compare February 7, 2025 06:16
@w41ter
Copy link
Contributor Author

w41ter commented Feb 7, 2025

run buildall

@w41ter w41ter force-pushed the pick_45061_to_origin_branch-2.1 branch from b4d4d72 to 3eb1538 Compare February 7, 2025 06:20
@w41ter w41ter requested a review from yiguolei February 8, 2025 02:50
@w41ter w41ter force-pushed the pick_45061_to_origin_branch-2.1 branch from 3eb1538 to 356347c Compare February 8, 2025 02:50
@w41ter
Copy link
Contributor Author

w41ter commented Feb 8, 2025

run buildall

@w41ter w41ter force-pushed the pick_45061_to_origin_branch-2.1 branch from 356347c to 27618de Compare February 8, 2025 07:46
@w41ter
Copy link
Contributor Author

w41ter commented Feb 8, 2025

run buildall

@w41ter
[feat](clone) Speed clone tablet via batch small file downloading (ap…
a74b551 
…ache#45061)

Downloading small files is too slow and might cause the clone tablet
task to time out. This PR supports a batch downloading API to speed up
the downloading of small files.

Before

```
succeed to copy tablet 10088, total file size: 19256126 B, cost: 78674 ms, rate: 0.244758 MB/s
```

After

```
succeed to copy tablet 30157, total files: 20006, total file size: 19311624 B, cost: 4016 ms, rate: 4.80867 MB/s
```
@w41ter w41ter force-pushed the pick_45061_to_origin_branch-2.1 branch from 27618de to a74b551 Compare February 8, 2025 08:05
@w41ter
Copy link
Contributor Author

w41ter commented Feb 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 8, 2025

TeamCity be ut coverage result:
Function Coverage: 36.49% (9607/26326)
Line Coverage: 28.08% (79618/283529)
Region Coverage: 26.74% (40837/152731)
Branch Coverage: 23.50% (20706/88098)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a74b551180b1beddebb4c1f81e79f8fbdf6be57e_a74b551180b1beddebb4c1f81e79f8fbdf6be57e/report/index.html

@w41ter
Copy link
Contributor Author

w41ter commented Feb 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 10, 2025

TeamCity be ut coverage result:
Function Coverage: 36.50% (9610/26326)
Line Coverage: 28.10% (79682/283563)
Region Coverage: 26.75% (40861/152739)
Branch Coverage: 23.51% (20713/88106)
Coverage Report: http://coverage.selectdb-in.cc/coverage/84ccff03b28f39b7ceeb1f57f216d25ad1b15b81_84ccff03b28f39b7ceeb1f57f216d25ad1b15b81/report/index.html

@dataroaring dataroaring merged commit 470030b into apache:branch-2.1 Feb 10, 2025
18 of 19 checks passed
@w41ter w41ter deleted the pick_45061_to_origin_branch-2.1 branch February 13, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@w41ter @doris-robot @dataroaring