[Bug] Fix bug of core local value #4523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating core local value from CoreDataAllocator, A lock is needed to protect the modification of _blocks.
chaoyli
requested changes
Sep 3, 2020
| } | ||
| private: | ||
| static constexpr int ELEMENTS_PER_BLOCK = BLOCK_SIZE / ELEMENT_BYTES; | ||
| SpinLock _lock; // lock to protect the modification of _blocks |
Contributor
There was a problem hiding this comment.
CoreData is to bind data to cpu to eliminate the lock.
If add a lock, it's design is meaningless.
Contributor
Author
There was a problem hiding this comment.
This is only used when creating the core local value (by calling get_or_create() of CoreDataAllocatorImpl).
And when creating the value, there is nothing to do with "cpu-bind".
The so called "cpu-bind" operation happens when accessing the CoreLocalValue,
not related to CoreDataAllocatorImpl
chaoyli
approved these changes
Sep 3, 2020
| } | ||
| private: | ||
| static constexpr int ELEMENTS_PER_BLOCK = BLOCK_SIZE / ELEMENT_BYTES; | ||
| SpinLock _lock; // lock to protect the modification of _blocks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When creating core local value from CoreDataAllocator,
A lock is needed to protect the modification of _blocks.
Types of changes
Checklist