Skip to content

[enhance](mtmv)Change the way to verify the existence of partition names when refreshing MTMV #45290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 5 commits into from
Dec 20, 2024
Merged

[enhance](mtmv)Change the way to verify the existence of partition names when refreshing MTMV #45290

morrySnow merged 5 commits into from
Dec 20, 2024

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Dec 11, 2024 •
edited
Loading

What problem does this PR solve?

Previously, when refreshing the materialized view according to the partition name, the existing partition of the materialized view was used to verify whether the partition name existed
After the change, the partition that should be present after refreshing the materialized view is used for verification

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Change the way to verify the existence of partition names when refreshing MTMV

Release note

Change the way to verify the existence of partition names when refreshing MTMV

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Dec 11, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Dec 11, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Dec 11, 2024

run p0

@morrySnow morrySnow added dev/2.1.x dev/3.0.x usercase Important user case type label labels Dec 13, 2024
@zddr
Copy link
Contributor Author

zddr commented Dec 13, 2024

run buildall

@zddr
Copy link
Contributor Author

zddr commented Dec 13, 2024

run p0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2024
@morrySnow morrySnow merged commit fc512ab into apache:master Dec 20, 2024
27 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
@zddr
[enhance](mtmv)Change the way to verify the existence of partition na…
0bd7f51 
…mes when refreshing MTMV (#45290)

### What problem does this PR solve?

Previously, when refreshing the materialized view according to the
partition name, the existing partition of the materialized view was used
to verify whether the partition name existed
After the change, the partition that should be present after refreshing
the materialized view is used for verification
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
@zddr
[enhance](mtmv)Change the way to verify the existence of partition na…
90ff135 
…mes when refreshing MTMV (#45290)

### What problem does this PR solve?

Previously, when refreshing the materialized view according to the
partition name, the existing partition of the materialized view was used
to verify whether the partition name existed
After the change, the partition that should be present after refreshing
the materialized view is used for verification
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 23, 2024
@github-actions @zddr
branch-2.1: [enhance](mtmv)Change the way to verify the existence of …
608000b 
…partition names when refreshing MTMV #45290 (#45725)

Cherry-picked from #45290

Co-authored-by: zhangdong <zhangdong@selectdb.com>
yiguolei pushed a commit that referenced this pull request Dec 23, 2024
@github-actions @zddr
branch-3.0: [enhance](mtmv)Change the way to verify the existence of …
01ab23e 
…partition names when refreshing MTMV #45290 (#45723)

Cherry-picked from #45290

Co-authored-by: zhangdong <zhangdong@selectdb.com>
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@seawinde seawinde seawinde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zddr @doris-robot @morrySnow @seawinde @yiguolei