Skip to content

[Bug][Compaction] fix wrong compaction failure time #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caoyang10 wants to merge 1 commit into from
Closed

[Bug][Compaction] fix wrong compaction failure time #4552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions be/src/olap/storage_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,11 @@ void StorageEngine::_perform_cumulative_compaction(DataDir* data_dir) {

OLAPStatus res = cumulative_compaction.compact();
if (res != OLAP_SUCCESS) {
best_tablet->set_last_cumu_compaction_failure_time(UnixMillis());
if (res == OLAP_ERR_BE_TRY_BE_LOCK_ERROR) {
best_tablet->set_last_cumu_compaction_failure_time(UnixMillis());
} else {
best_tablet->set_last_cumu_compaction_failure_time(0);
}
if (res != OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSIONS) {
DorisMetrics::instance()->cumulative_compaction_request_failed->increment(1);
LOG(WARNING) << "failed to do cumulative compaction. res=" << res
Expand Down Expand Up @@ -638,7 +642,11 @@ void StorageEngine::_perform_base_compaction(DataDir* data_dir) {
BaseCompaction base_compaction(best_tablet, tracker_label, _compaction_mem_tracker);
OLAPStatus res = base_compaction.compact();
if (res != OLAP_SUCCESS) {
best_tablet->set_last_base_compaction_failure_time(UnixMillis());
if (res == OLAP_ERR_BE_TRY_BE_LOCK_ERROR) {
best_tablet->set_last_base_compaction_failure_time(UnixMillis());
} else {
best_tablet->set_last_base_compaction_failure_time(0);
}
if (res != OLAP_ERR_BE_NO_SUITABLE_VERSION) {
DorisMetrics::instance()->base_compaction_request_failed->increment(1);
LOG(WARNING) << "failed to init base compaction. res=" << res
Expand Down