Skip to content

branch-2.1: [Fix](ORC) Not push down fixed char type in orc reader #45484 #45525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 3 commits into from
Dec 19, 2024
Merged

branch-2.1: [Fix](ORC) Not push down fixed char type in orc reader #45484 #45525

yiguolei merged 3 commits into from
Dec 19, 2024

Conversation

@suxiaogang223
Copy link
Contributor

@suxiaogang223 suxiaogang223 commented Dec 17, 2024 •
edited by morningman
Loading

cherry-pick #45484

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Dec 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

kaka11chen
kaka11chen approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 17, 2024

TeamCity be ut coverage result:
Function Coverage: 36.46% (9568/26239)
Line Coverage: 27.92% (78621/281604)
Region Coverage: 26.60% (40369/151776)
Branch Coverage: 23.35% (20444/87544)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a3585e4b4ada4e3d19c139d6320f6dca3d220b72_a3585e4b4ada4e3d19c139d6320f6dca3d220b72/report/index.html

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Dec 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.47% (9569/26241)
Line Coverage: 27.91% (78622/281648)
Region Coverage: 26.59% (40369/151802)
Branch Coverage: 23.35% (20443/87558)
Coverage Report: http://coverage.selectdb-in.cc/coverage/172446811f386148eb9ba7661ddccdb986b812a5_172446811f386148eb9ba7661ddccdb986b812a5/report/index.html

@suxiaogang223 suxiaogang223 marked this pull request as draft December 18, 2024 09:13
@suxiaogang223 suxiaogang223 marked this pull request as ready for review December 18, 2024 09:33
@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Dec 18, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@doris-robot
Copy link

doris-robot commented Dec 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.46% (9568/26241)
Line Coverage: 27.93% (78658/281632)
Region Coverage: 26.60% (40373/151790)
Branch Coverage: 23.35% (20444/87548)
Coverage Report: http://coverage.selectdb-in.cc/coverage/744c225798c807d96fd10cf75e5a1bc06d950803_744c225798c807d96fd10cf75e5a1bc06d950803/report/index.html

@suxiaogang223
Copy link
Contributor Author

suxiaogang223 commented Dec 18, 2024

run p0

@yiguolei
Copy link
Contributor

yiguolei commented Dec 18, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.47% (9569/26241)
Line Coverage: 27.93% (78657/281643)
Region Coverage: 26.60% (40375/151803)
Branch Coverage: 23.36% (20450/87560)
Coverage Report: http://coverage.selectdb-in.cc/coverage/475fe57527882824ecc71e909a07cbd37a903b52_475fe57527882824ecc71e909a07cbd37a903b52/report/index.html

@yiguolei yiguolei merged commit 7d32e4f into apache:branch-2.1 Dec 19, 2024
20 of 22 checks passed
morningman pushed a commit to morningman/doris that referenced this pull request Feb 8, 2025
@suxiaogang223 @morningman
branch-3.0: [Fix](ORC) Not push down fixed char type in orc reader ap…
cd4c5b1 
…ache#45484 (apache#45525)

cherry-pick apache#45484
@morningman morningman mentioned this pull request Feb 8, 2025
Merged
morningman added a commit that referenced this pull request Feb 9, 2025
@morningman @suxiaogang223
[revert](orc) revert orc predicate pushdown related commits (#47662)
7ed947e 
revert:
branch-3.0: [fix](orc) ignore null values when the literals of
in_predicate contains #45104 (#45586)
[fix](orc) check all the cases before build_search_argument (#44615)
(#44802)
branch-3.0: [enhance](orc) Optimize ORC Predicate Pushdown for
OR-connected Predicate #43255 (#44436)

re-pick:
branch-3.0: [Fix](ORC) Not push down fixed char type in orc reader
#45484 (#45525)

---------

Co-authored-by: Socrates <suyiteng@selectdb.com>
morningman added a commit that referenced this pull request Feb 17, 2025
@morningman
Revert "branch-2.1: [Fix](ORC) Not push down fixed char type in orc r…
da21285 
…eader #45484 (#45525)"

This reverts commit 7d32e4f.
@suxiaogang223 suxiaogang223 deleted the fix_orc_fixed_char branch March 11, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kaka11chen kaka11chen kaka11chen approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suxiaogang223 @hello-stephen @doris-robot @yiguolei @kaka11chen