-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](inverted index) Add NumInvertedIndexRemoteIOTotal statistics in profile #44863 #45619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… profile (apache#44863) Add NumInvertedIndexRemoteIOTotal to count the number of remote IO operations in the inverted index Related PR: apache#43542
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| } | ||
|
|
||
| Status InvertedIndexFileReader::_init_from_v2(int32_t read_buffer_size) { | ||
| Status InvertedIndexFileReader::_init_from(int32_t read_buffer_size, const io::IOContext* io_ctx) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function '_init_from' exceeds recommended size/complexity thresholds [readability-function-size]
Status InvertedIndexFileReader::_init_from(int32_t read_buffer_size, const io::IOContext* io_ctx) {
^Additional context
be/src/olap/rowset/segment_v2/inverted_index_file_reader.cpp:49: 94 lines including whitespace and comments (threshold 80)
Status InvertedIndexFileReader::_init_from(int32_t read_buffer_size, const io::IOContext* io_ctx) {
^
TPC-H: Total hot run time: 40795 ms |
TPC-DS: Total hot run time: 196333 ms |
#44863