-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](cloud-mow) FE should release delete bitmap lock when calculating delete bitmap failed #45673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g delete bitmap failed
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 39978 ms |
TPC-DS: Total hot run time: 196410 ms |
ClickBench: Total hot run time: 32.36 s |
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Outdated
Show resolved
Hide resolved
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39923 ms |
TPC-DS: Total hot run time: 196693 ms |
ClickBench: Total hot run time: 32.82 s |
|
run buildall |
TPC-H: Total hot run time: 39654 ms |
TPC-DS: Total hot run time: 190121 ms |
ClickBench: Total hot run time: 32.82 s |
|
run buildall |
TPC-H: Total hot run time: 32315 ms |
TPC-DS: Total hot run time: 196180 ms |
ClickBench: Total hot run time: 31.69 s |
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Outdated
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 32397 ms |
TPC-DS: Total hot run time: 196613 ms |
ClickBench: Total hot run time: 31.58 s |
|
run buildall |
TPC-H: Total hot run time: 32321 ms |
TPC-DS: Total hot run time: 197063 ms |
ClickBench: Total hot run time: 31.79 s |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| commitTransaction(dbId, tableList, transactionId, tabletCommitInfos, txnCommitAttachment, false); | ||
| List<OlapTable> mowTableList = getMowTableList(tableList, tabletCommitInfos); | ||
| try { | ||
| LOG.info("try to commit transaction, transactionId: {}", transactionId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the log ncessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this log record when current transaction successfully getting fe's commitLock and start do get delete bitmap lock, it's useful for checking problem
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…g delete bitmap failed apache#45673
…g delete bitmap failed apache#45673
When calculating delete bitmap failed, delete bitmap lock is holded by last failed txn, fe should release lock for other txn can do commit.
Issue Number: close #xxx
Related PR: #41759
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)