Skip to content

[enhancement](cloud) add profile counter for file cache #45678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Dec 25, 2024
Merged

[enhancement](cloud) add profile counter for file cache #45678

dataroaring merged 1 commit into from
Dec 25, 2024

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Dec 19, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[enhancement](cloud) add profile counter for file cache
16f63e1 
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas
Copy link
Contributor

Thearas commented Dec 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Dec 19, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Dec 19, 2024

TeamCity be ut coverage result:
Function Coverage: 38.87% (10129/26061)
Line Coverage: 29.79% (85181/285971)
Region Coverage: 28.90% (43462/150391)
Branch Coverage: 25.41% (22141/87130)
Coverage Report: http://coverage.selectdb-in.cc/coverage/16f63e1698c3efb7bed467998fdadd1f7fcc0ae7_16f63e1698c3efb7bed467998fdadd1f7fcc0ae7/report/index.html

yiguolei
yiguolei approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

PR approved by anyone and no changes requested.

@freemandealer
Copy link
Contributor Author

freemandealer commented Dec 20, 2024

run cloud_p0

@freemandealer
Copy link
Contributor Author

freemandealer commented Dec 20, 2024

run p0

gavinchou
gavinchou reviewed Dec 23, 2024
View reviewed changes
be/src/io/cache/file_cache_common.h
bool operator==(const UInt128Wrapper& other) const { return value_ == other.value_; }
};

struct ReadStatistics {
Copy link
Contributor

@gavinchou gavinchou Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment for each field
e.g. what is get/set_timer?

@dataroaring dataroaring merged commit ce7691d into apache:master Dec 25, 2024
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
@freemandealer
[enhancement](cloud) add profile counter for file cache (#45678)
0ab0906
@github-actions github-actions bot mentioned this pull request Dec 25, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 26, 2024
@github-actions @freemandealer
branch-3.0: [enhancement](cloud) add profile counter for file cache #…
af2d628 
…45678 (#45892)

Cherry-picked from #45678

Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
hubgeter pushed a commit to hubgeter/doris that referenced this pull request Mar 12, 2025
@freemandealer
(selectdb-cloud) pick file cache for 4.0 apache#47472 apache#46561 ap…
114ce8f 
…ache#45678 apache#47473 apache#47609 (apache#3746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@yiguolei yiguolei yiguolei approved these changes

@platoneko platoneko Awaiting requested review from platoneko

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer @Thearas @doris-robot @gavinchou @yiguolei @dataroaring