Skip to content

branch-2.1: [improve](variant) only sanitize in debug mode #45689 #45698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Dec 20, 2024
Merged

branch-2.1: [improve](variant) only sanitize in debug mode #45689 #45698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions be/src/vec/columns/column_object.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,6 +1702,7 @@ std::string ColumnObject::debug_string() const {
}

Status ColumnObject::sanitize() const {
#ifndef NDEBUG
RETURN_IF_CATCH_EXCEPTION(check_consistency());
for (const auto& subcolumn : subcolumns) {
if (subcolumn->data.is_finalized()) {
Expand All @@ -1716,6 +1717,7 @@ Status ColumnObject::sanitize() const {
}

VLOG_DEBUG << "sanitized " << debug_string();
#endif
return Status::OK();
}

Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/columns/column_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ class ColumnObject final : public COWHelper<IColumn, ColumnObject> {

bool empty() const;

// Check if all columns and types are aligned
// Check if all columns and types are aligned, only in debug mode
Status sanitize() const;

std::string debug_string() const;
Expand Down
Loading