Skip to content

Conversation

@Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Sep 10, 2020

Proposed changes

Support alter table syntax for sequence column

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix Support Alter Table syntax for SEQUENCE COLUMN #4560 ), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Youngwb Youngwb requested a review from yangzhg September 11, 2020 03:37
yangzhg
yangzhg previously approved these changes Sep 11, 2020
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 12, 2020
@morningman
Copy link
Contributor

hi @Youngwb , could you please add document for this new feature?

@Youngwb
Copy link
Contributor Author

Youngwb commented Sep 12, 2020

@morningman I have updated the document

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yangzhg yangzhg merged commit 95111f9 into apache:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Alter Table syntax for SEQUENCE COLUMN

3 participants