[Bug] Fix bug of cumulative compaction and deletion of stale version #4593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting candicate rowsets to do the cumulative compaction, some rowsets may not be selected because the protection time has not expired. Therefore, we need to find the current longest continuous version path in the candicate rowsets.
morningman
added
kind/fix
Contributor
|
LGTM |
imay
reviewed
Oct 14, 2020
be/src/olap/compaction.cpp
Outdated
| for (; i < rowsets->size(); ++i) { | ||
| RowsetSharedPtr rowset = (*rowsets)[i]; | ||
| if (rowset->start_version() != prev_rowset->end_version() + 1) { | ||
| LOG(WARNING) << "There are missed versions among rowsets. " |
Contributor
There was a problem hiding this comment.
Is it appropriate to print the warning log here?
I think this function only deals with specific logic, and the caller can decide whether to print the log. This allows this function to be used in more scenarios.
imay
reviewed
Oct 17, 2020
Co-authored-by: Zhao Chun <buaa.zhaoc@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When selecting candicate rowsets to do the cumulative compaction,
some rowsets may not be selected because the protection time has not expired.
Therefore, we need to find the current longest continuous version path in the candicate rowsets.
Types of changes
Checklist