Skip to content

[fix](nereids)allow in partition contains MAX_VALUE #46076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hello-stephen merged 1 commit into from
Dec 27, 2024
Merged

[fix](nereids)allow in partition contains MAX_VALUE #46076

hello-stephen merged 1 commit into from
Dec 27, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Dec 27, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

starocean999 commented Dec 27, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 27, 2024

skip buildall

@hello-stephen hello-stephen merged commit ec29e7d into apache:master Dec 27, 2024
27 of 28 checks passed
@doris-robot
Copy link

doris-robot commented Dec 27, 2024

TPC-H: Total hot run time: 32529 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit addbc306c532f9cd58ab3738eeb8b15d8fa7c142, data reload: false

------ Round 1 ----------------------------------
q1	17587	6177	6052	6052
q2	2035	304	175	175
q3	10409	1243	690	690
q4	10210	861	420	420
q5	7531	2181	1948	1948
q6	203	180	149	149
q7	898	747	600	600
q8	9223	1354	1144	1144
q9	5299	4981	4937	4937
q10	6797	2342	1842	1842
q11	480	283	252	252
q12	350	355	209	209
q13	17766	3570	2938	2938
q14	234	237	224	224
q15	562	511	518	511
q16	645	623	583	583
q17	548	843	329	329
q18	7092	6493	6481	6481
q19	1219	977	561	561
q20	301	320	190	190
q21	2756	2138	1976	1976
q22	367	338	318	318
Total cold run time: 102512 ms
Total hot run time: 32529 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6218	6243	6223	6223
q2	235	320	233	233
q3	2205	2618	2292	2292
q4	1389	1783	1365	1365
q5	4344	4728	4727	4727
q6	182	174	146	146
q7	2126	1972	1861	1861
q8	2590	2813	2682	2682
q9	7329	7222	7185	7185
q10	3054	3342	2792	2792
q11	603	541	503	503
q12	680	742	593	593
q13	3401	3799	3073	3073
q14	304	288	259	259
q15	572	528	520	520
q16	661	697	648	648
q17	1227	1748	1252	1252
q18	7657	7494	7296	7296
q19	797	1142	1027	1027
q20	1900	1980	1805	1805
q21	5511	5152	4781	4781
q22	589	609	626	609
Total cold run time: 53574 ms
Total hot run time: 51872 ms

@doris-robot
Copy link

doris-robot commented Dec 27, 2024

TPC-DS: Total hot run time: 190079 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit addbc306c532f9cd58ab3738eeb8b15d8fa7c142, data reload: false

query1	961	393	377	377
query2	6519	2434	2310	2310
query3	6705	218	209	209
query4	34046	23748	23556	23556
query5	4352	621	472	472
query6	294	213	197	197
query7	4621	488	309	309
query8	299	233	237	233
query9	9564	2743	2728	2728
query10	445	301	242	242
query11	18184	15810	15141	15141
query12	151	108	100	100
query13	1647	535	404	404
query14	10741	8262	7168	7168
query15	263	205	176	176
query16	7567	572	459	459
query17	1595	718	551	551
query18	1252	353	292	292
query19	228	186	151	151
query20	119	116	115	115
query21	210	123	137	123
query22	4380	4516	4233	4233
query23	34692	33617	33283	33283
query24	6456	2289	2345	2289
query25	471	454	383	383
query26	1065	272	153	153
query27	2014	461	331	331
query28	5326	2481	2410	2410
query29	600	531	415	415
query30	227	182	160	160
query31	976	887	796	796
query32	78	60	59	59
query33	493	329	298	298
query34	764	836	517	517
query35	801	820	774	774
query36	1001	1046	953	953
query37	115	102	76	76
query38	4208	4376	4141	4141
query39	1475	1445	1430	1430
query40	209	119	106	106
query41	51	49	49	49
query42	116	103	102	102
query43	523	540	496	496
query44	1303	802	805	802
query45	182	174	175	174
query46	861	1042	647	647
query47	1919	1909	1851	1851
query48	375	413	327	327
query49	798	463	374	374
query50	605	641	396	396
query51	7174	7035	7118	7035
query52	99	99	90	90
query53	219	262	185	185
query54	472	484	390	390
query55	81	79	78	78
query56	296	253	264	253
query57	1177	1169	1114	1114
query58	233	224	225	224
query59	3087	3146	2971	2971
query60	281	262	243	243
query61	112	110	105	105
query62	831	803	732	732
query63	223	191	192	191
query64	4084	979	622	622
query65	3243	3181	3247	3181
query66	815	422	304	304
query67	15867	15756	15394	15394
query68	9402	745	526	526
query69	462	281	255	255
query70	1241	1149	1054	1054
query71	450	292	250	250
query72	5830	3858	3863	3858
query73	1183	742	355	355
query74	10187	9294	9282	9282
query75	4602	3147	2650	2650
query76	5597	1219	773	773
query77	1028	366	268	268
query78	10111	10199	9317	9317
query79	4981	884	588	588
query80	738	505	417	417
query81	483	266	226	226
query82	315	153	134	134
query83	202	171	143	143
query84	283	91	74	74
query85	752	378	300	300
query86	339	329	302	302
query87	4683	4414	4311	4311
query88	3664	2243	2197	2197
query89	442	335	296	296
query90	2117	191	188	188
query91	132	132	105	105
query92	65	56	50	50
query93	3120	863	521	521
query94	682	401	285	285
query95	330	260	244	244
query96	488	612	288	288
query97	2711	2828	2720	2720
query98	216	199	209	199
query99	1626	1523	1453	1453
Total cold run time: 298603 ms
Total hot run time: 190079 ms

@doris-robot
Copy link

doris-robot commented Dec 27, 2024

ClickBench: Total hot run time: 30.96 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit addbc306c532f9cd58ab3738eeb8b15d8fa7c142, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.61	0.10	0.11
query5	0.41	0.42	0.40
query6	1.17	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.50	0.50
query10	0.54	0.55	0.55
query11	0.15	0.11	0.12
query12	0.13	0.11	0.11
query13	0.61	0.61	0.61
query14	2.77	2.83	2.84
query15	0.90	0.81	0.83
query16	0.39	0.38	0.37
query17	1.01	1.02	1.04
query18	0.22	0.20	0.20
query19	1.94	1.86	1.99
query20	0.02	0.00	0.01
query21	15.38	0.88	0.60
query22	0.76	0.79	0.61
query23	15.35	1.42	0.59
query24	3.63	1.46	0.58
query25	0.21	0.12	0.17
query26	0.25	0.14	0.14
query27	0.05	0.04	0.06
query28	13.45	1.56	1.05
query29	12.59	3.92	3.29
query30	0.25	0.10	0.08
query31	2.81	0.60	0.36
query32	3.23	0.55	0.46
query33	3.16	3.08	3.17
query34	16.77	5.19	4.44
query35	4.50	4.45	4.48
query36	0.65	0.49	0.47
query37	0.10	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.12
query41	0.07	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.38 s
Total hot run time: 30.96 s

github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
@starocean999
[fix](nereids)allow in partition contains MAX_VALUE (#46076)
87db8ec
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jun 17, 2025
@github-actions @starocean999
branch-3.0: [fix](nereids)allow in partition contains MAX_VALUE #46076 (
5a7618f 
#51806)

Cherry-picked from #46076

Co-authored-by: starocean999 <lichi@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jun 19, 2025
@starocean999
[fix](nereids)allow in partition contains MAX_VALUE (#46076)
bccda03
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
@github-actions @starocean999
branch-3.1: [fix](nereids)allow in partition contains MAX_VALUE #46076 (
09c5530 
#51962)

Cherry-picked from #46076

Co-authored-by: starocean999 <lichi@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@starocean999 @Thearas @hello-stephen @doris-robot @morrySnow @dataroaring