Skip to content

[fix](Nereids) fix log and power #46077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
englefly merged 2 commits into from
Dec 30, 2024
Merged

[fix](Nereids) fix log and power #46077

englefly merged 2 commits into from
Dec 30, 2024

Conversation

@LiBinfeng-01
Copy link
Contributor

@LiBinfeng-01 LiBinfeng-01 commented Dec 27, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #40744

Problem Summary:
log should not have 1 as the first value, power should not have negative number and non-integer as input at the same time, or it
would result in non-real number

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Dec 27, 2024

run buildall

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Dec 27, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 27, 2024

TPC-H: Total hot run time: 33153 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 34f33b1b1e1ab51b26b76618a791400012365e66, data reload: false

------ Round 1 ----------------------------------
q1	17725	6164	6046	6046
q2	2035	325	171	171
q3	10746	1292	737	737
q4	11177	869	425	425
q5	7476	2225	1963	1963
q6	210	191	145	145
q7	899	761	596	596
q8	9232	1320	1179	1179
q9	5176	4938	4950	4938
q10	6762	2304	1862	1862
q11	482	284	261	261
q12	347	353	214	214
q13	20420	3621	3031	3031
q14	239	237	210	210
q15	561	515	499	499
q16	624	604	584	584
q17	569	930	350	350
q18	8506	6896	6879	6879
q19	3976	1010	548	548
q20	296	312	192	192
q21	2878	2247	2001	2001
q22	379	349	322	322
Total cold run time: 110715 ms
Total hot run time: 33153 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6606	6286	6149	6149
q2	239	333	230	230
q3	2269	2663	2347	2347
q4	1440	1838	1391	1391
q5	4440	4984	4980	4980
q6	188	183	140	140
q7	2095	1958	1861	1861
q8	2590	2788	2651	2651
q9	7299	7270	7132	7132
q10	2992	3393	2813	2813
q11	598	528	506	506
q12	661	780	697	697
q13	3413	3702	3202	3202
q14	301	314	277	277
q15	558	522	493	493
q16	636	692	652	652
q17	1229	1757	1235	1235
q18	7814	7444	7266	7266
q19	854	1012	1148	1012
q20	1966	2000	1888	1888
q21	5597	5241	5174	5174
q22	616	631	606	606
Total cold run time: 54401 ms
Total hot run time: 52702 ms

@doris-robot
Copy link

doris-robot commented Dec 27, 2024

TPC-DS: Total hot run time: 197673 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 34f33b1b1e1ab51b26b76618a791400012365e66, data reload: false

query1	1277	962	915	915
query2	6398	2310	2346	2310
query3	10954	4784	4691	4691
query4	33081	23796	23449	23449
query5	4446	614	441	441
query6	296	205	190	190
query7	3994	496	330	330
query8	310	264	239	239
query9	9276	2762	2764	2762
query10	476	329	252	252
query11	18404	15421	15232	15232
query12	169	108	104	104
query13	1735	529	404	404
query14	10995	7973	8017	7973
query15	254	199	189	189
query16	7853	624	480	480
query17	1520	794	581	581
query18	2118	415	296	296
query19	204	189	161	161
query20	111	113	111	111
query21	199	128	103	103
query22	4391	4520	4356	4356
query23	34282	34090	33486	33486
query24	6068	2309	2384	2309
query25	493	460	429	429
query26	718	276	161	161
query27	1959	477	340	340
query28	5604	2532	2510	2510
query29	608	584	452	452
query30	227	193	153	153
query31	970	929	837	837
query32	74	67	64	64
query33	509	400	297	297
query34	759	843	516	516
query35	812	849	777	777
query36	1020	1059	950	950
query37	110	95	78	78
query38	4110	4246	4399	4246
query39	1567	1487	1627	1487
query40	207	118	100	100
query41	44	42	43	42
query42	114	104	112	104
query43	528	545	503	503
query44	1309	831	828	828
query45	181	174	168	168
query46	882	1072	654	654
query47	2001	2002	1949	1949
query48	388	415	329	329
query49	701	472	393	393
query50	651	669	399	399
query51	7292	7370	7412	7370
query52	98	100	90	90
query53	222	255	193	193
query54	472	483	411	411
query55	85	76	78	76
query56	268	260	261	260
query57	1228	1224	1159	1159
query58	237	224	229	224
query59	3406	3377	3246	3246
query60	267	267	248	248
query61	116	107	111	107
query62	876	818	814	814
query63	233	201	195	195
query64	2771	1018	692	692
query65	3373	3264	3210	3210
query66	908	408	327	327
query67	16515	15806	15523	15523
query68	9047	748	512	512
query69	489	293	257	257
query70	1203	1170	1154	1154
query71	441	281	263	263
query72	6278	3840	3924	3840
query73	664	755	368	368
query74	10219	9171	8900	8900
query75	4649	3138	2638	2638
query76	5253	1193	775	775
query77	893	353	276	276
query78	10076	10300	9320	9320
query79	3354	891	589	589
query80	704	506	455	455
query81	477	271	236	236
query82	641	156	119	119
query83	201	157	141	141
query84	280	88	70	70
query85	838	344	303	303
query86	348	319	298	298
query87	4682	4540	4369	4369
query88	3865	2254	2201	2201
query89	423	326	291	291
query90	1906	192	192	192
query91	135	130	106	106
query92	63	56	52	52
query93	1422	894	532	532
query94	645	399	275	275
query95	326	267	249	249
query96	489	611	276	276
query97	2749	2849	2665	2665
query98	219	209	204	204
query99	1665	1543	1472	1472
Total cold run time: 298368 ms
Total hot run time: 197673 ms

@doris-robot
Copy link

doris-robot commented Dec 27, 2024

ClickBench: Total hot run time: 31.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 34f33b1b1e1ab51b26b76618a791400012365e66, data reload: false

query1	0.04	0.04	0.02
query2	0.06	0.03	0.04
query3	0.24	0.07	0.07
query4	1.63	0.10	0.11
query5	0.41	0.43	0.40
query6	1.16	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.02	0.04
query9	0.59	0.52	0.50
query10	0.56	0.57	0.54
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	2.82	2.84	2.78
query15	0.89	0.82	0.84
query16	0.40	0.38	0.39
query17	1.07	1.06	1.05
query18	0.22	0.20	0.20
query19	1.88	1.72	2.02
query20	0.01	0.01	0.02
query21	15.39	0.95	0.59
query22	0.77	0.83	0.96
query23	15.02	1.35	0.51
query24	2.77	0.90	1.89
query25	0.21	0.20	0.14
query26	0.24	0.16	0.13
query27	0.04	0.06	0.04
query28	14.39	1.49	1.05
query29	12.63	3.89	3.24
query30	0.25	0.09	0.07
query31	2.84	0.58	0.37
query32	3.23	0.55	0.46
query33	3.13	3.10	3.08
query34	16.70	5.09	4.50
query35	4.41	4.48	4.47
query36	0.66	0.50	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.11 s
Total hot run time: 31.31 s

@LiBinfeng-01
Copy link
Contributor Author

LiBinfeng-01 commented Dec 30, 2024

run external

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024

PR approved by anyone and no changes requested.

@englefly englefly merged commit 7cce1a4 into apache:master Dec 30, 2024
24 of 25 checks passed
zclllyybb
zclllyybb approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
[fix](Nereids) fix log and power (#46077)
56b1b37 
### What problem does this PR solve?
Problem Summary:
log should not have 1 as the first value, power should not have negative
number and non-integer as input at the same time, or it
would result in non-real number
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
[fix](Nereids) fix log and power (#46077)
24bd26c 
### What problem does this PR solve?
Problem Summary:
log should not have 1 as the first value, power should not have negative
number and non-integer as input at the same time, or it
would result in non-real number
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 8, 2025
@github-actions
branch-2.1: [fix](Nereids) fix log and power #46077 (#46635)
b99ef07 
Cherry-picked from #46077

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
@morrySnow morrySnow added the usercase Important user case type label label Jan 13, 2025
morrySnow pushed a commit that referenced this pull request Jan 13, 2025
@github-actions
branch-3.0: [fix](Nereids) fix log and power #46077 (#46636)
5c1e377 
Cherry-picked from #46077

Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
fix(Nereids): fix log and power apache#46077 (apache#46635)
117b177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

+1 more reviewer

@yagagagaga yagagagaga yagagagaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged p0_b reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@LiBinfeng-01 @Thearas @doris-robot @englefly @yagagagaga @zclllyybb @yiguolei @morrySnow