Skip to content

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Related PR: #33591

Problem Summary:

when CTEAnchoer not exists in plan, cost based rewrite job could not get correct cost from applied cbo rewrite rule plan.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33663 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f92399b67d865047ab1defa770107b61c07dc53e, data reload: false

------ Round 1 ----------------------------------
q1	17573	6177	6057	6057
q2	2106	1370	1216	1216
q3	10018	1256	730	730
q4	10208	879	465	465
q5	7511	2196	1962	1962
q6	203	175	145	145
q7	908	756	614	614
q8	9253	1379	1187	1187
q9	5284	4917	4967	4917
q10	6750	2292	1890	1890
q11	500	281	264	264
q12	335	361	224	224
q13	17767	3541	2960	2960
q14	238	233	225	225
q15	557	496	523	496
q16	631	617	588	588
q17	566	845	320	320
q18	7067	6584	6368	6368
q19	1908	953	542	542
q20	305	311	183	183
q21	3061	2234	2001	2001
q22	360	339	309	309
Total cold run time: 103109 ms
Total hot run time: 33663 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6287	6245	6250	6245
q2	233	322	229	229
q3	2288	2643	2336	2336
q4	1443	1840	1451	1451
q5	4336	4775	4904	4775
q6	192	177	140	140
q7	2107	1982	1834	1834
q8	2631	2826	2737	2737
q9	7202	7275	7213	7213
q10	3073	3336	2818	2818
q11	594	521	519	519
q12	637	762	610	610
q13	3397	3741	3147	3147
q14	293	299	277	277
q15	576	511	533	511
q16	684	685	649	649
q17	1207	1739	1252	1252
q18	7698	7505	7228	7228
q19	773	1058	1103	1058
q20	2005	2001	1953	1953
q21	5616	5333	4976	4976
q22	642	630	556	556
Total cold run time: 53914 ms
Total hot run time: 52514 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197342 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f92399b67d865047ab1defa770107b61c07dc53e, data reload: false

query1	1327	957	920	920
query2	6237	2331	2295	2295
query3	11279	4942	5006	4942
query4	33169	23908	23445	23445
query5	4379	625	456	456
query6	294	197	190	190
query7	3984	490	300	300
query8	316	267	246	246
query9	9506	2778	2754	2754
query10	470	316	257	257
query11	18022	15461	15295	15295
query12	167	111	106	106
query13	1605	545	412	412
query14	10656	7677	7532	7532
query15	230	193	192	192
query16	7907	685	478	478
query17	1566	764	582	582
query18	2068	404	319	319
query19	210	193	154	154
query20	123	116	104	104
query21	201	159	111	111
query22	4771	4699	4437	4437
query23	35142	34015	34298	34015
query24	6533	2310	2319	2310
query25	465	456	391	391
query26	785	282	152	152
query27	1987	466	322	322
query28	5147	2509	2482	2482
query29	598	565	419	419
query30	208	183	151	151
query31	981	929	830	830
query32	71	59	55	55
query33	468	350	289	289
query34	787	840	522	522
query35	815	841	781	781
query36	1031	1060	966	966
query37	121	107	78	78
query38	4121	4362	4224	4224
query39	1496	1479	1465	1465
query40	206	119	97	97
query41	45	44	45	44
query42	126	102	104	102
query43	526	542	510	510
query44	1282	827	820	820
query45	189	177	175	175
query46	903	1088	663	663
query47	1979	2014	1897	1897
query48	385	405	339	339
query49	704	481	383	383
query50	631	663	408	408
query51	7253	7363	7081	7081
query52	101	100	89	89
query53	225	250	181	181
query54	472	496	437	437
query55	85	77	76	76
query56	259	257	242	242
query57	1197	1162	1114	1114
query58	233	217	222	217
query59	3079	3108	3013	3013
query60	271	264	246	246
query61	105	109	108	108
query62	865	806	725	725
query63	231	194	194	194
query64	3135	1004	639	639
query65	3266	3312	3189	3189
query66	685	405	327	327
query67	15986	15859	15436	15436
query68	9582	752	509	509
query69	489	288	249	249
query70	1235	1140	1142	1140
query71	451	281	250	250
query72	5936	3909	3869	3869
query73	983	752	367	367
query74	10183	8941	9023	8941
query75	4685	3155	2657	2657
query76	5586	1188	768	768
query77	1011	373	274	274
query78	10126	10246	9376	9376
query79	2795	898	623	623
query80	725	522	433	433
query81	498	273	232	232
query82	368	152	129	129
query83	190	169	152	152
query84	287	88	66	66
query85	825	358	308	308
query86	346	312	299	299
query87	4480	4488	4615	4488
query88	3291	2247	2195	2195
query89	424	342	291	291
query90	1990	192	190	190
query91	131	136	106	106
query92	61	51	56	51
query93	1512	887	511	511
query94	655	394	290	290
query95	330	265	246	246
query96	497	603	285	285
query97	2727	2834	2687	2687
query98	229	199	200	199
query99	1979	1558	1430	1430
Total cold run time: 298274 ms
Total hot run time: 197342 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f92399b67d865047ab1defa770107b61c07dc53e, data reload: false

query1	0.03	0.04	0.02
query2	0.08	0.03	0.03
query3	0.23	0.07	0.07
query4	1.61	0.10	0.11
query5	0.41	0.41	0.42
query6	1.16	0.65	0.66
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.51
query10	0.55	0.60	0.55
query11	0.16	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.72	2.75	2.72
query15	0.89	0.83	0.82
query16	0.38	0.39	0.37
query17	1.03	0.99	1.00
query18	0.22	0.20	0.21
query19	1.90	2.01	1.82
query20	0.01	0.01	0.01
query21	15.40	0.91	0.61
query22	0.75	0.76	0.77
query23	15.19	1.43	0.54
query24	3.00	1.92	1.49
query25	0.14	0.13	0.09
query26	0.33	0.14	0.14
query27	0.06	0.04	0.04
query28	14.06	1.48	1.04
query29	12.58	3.88	3.25
query30	0.25	0.10	0.07
query31	2.81	0.59	0.37
query32	3.24	0.55	0.46
query33	3.11	3.14	3.10
query34	16.67	5.13	4.49
query35	4.54	4.53	4.49
query36	0.64	0.50	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.12	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106 s
Total hot run time: 31.84 s

@cambyzju
Copy link
Contributor

Does branch-2.0 need this pr?

Related PR: #33591 already merged into branch-2.0

@morrySnow morrySnow force-pushed the fix_cbo_rewrite_not_work branch from f92399b to 4f78110 Compare January 3, 2025 03:19
@morrySnow morrySnow marked this pull request as draft January 3, 2025 03:44
@morrySnow morrySnow force-pushed the fix_cbo_rewrite_not_work branch from 4f78110 to ae17f74 Compare January 16, 2025 04:08
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32196 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ae17f748ded7cd397a769872c770cbee2ead8f2b, data reload: false

------ Round 1 ----------------------------------
q1	17584	5370	5426	5370
q2	2056	304	175	175
q3	10427	1249	732	732
q4	10245	961	514	514
q5	8457	2390	2122	2122
q6	196	164	132	132
q7	899	744	604	604
q8	9255	1399	1178	1178
q9	5237	4854	4918	4854
q10	6827	2341	1886	1886
q11	476	277	259	259
q12	342	353	220	220
q13	17753	3672	3077	3077
q14	232	237	212	212
q15	516	478	470	470
q16	653	618	588	588
q17	567	879	332	332
q18	7188	6487	6502	6487
q19	1510	968	541	541
q20	308	322	190	190
q21	2773	2124	1944	1944
q22	366	345	309	309
Total cold run time: 103867 ms
Total hot run time: 32196 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5516	5485	5479	5479
q2	236	326	239	239
q3	2258	2689	2363	2363
q4	1435	1839	1445	1445
q5	4357	4734	4666	4666
q6	167	159	126	126
q7	2068	1922	1829	1829
q8	2588	2845	2686	2686
q9	7293	7262	7230	7230
q10	3056	3296	2818	2818
q11	572	499	477	477
q12	653	741	586	586
q13	3485	3982	3314	3314
q14	298	303	290	290
q15	521	477	467	467
q16	659	699	662	662
q17	1219	1750	1255	1255
q18	7634	7500	7537	7500
q19	803	1098	1084	1084
q20	1978	2031	1883	1883
q21	5787	5130	4948	4948
q22	660	619	570	570
Total cold run time: 53243 ms
Total hot run time: 51917 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194024 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ae17f748ded7cd397a769872c770cbee2ead8f2b, data reload: false

query1	1317	948	933	933
query2	6480	2064	1978	1978
query3	10995	4475	4408	4408
query4	32523	23724	22878	22878
query5	3750	621	461	461
query6	291	200	198	198
query7	3982	496	305	305
query8	280	243	216	216
query9	9281	2657	2629	2629
query10	475	311	247	247
query11	17528	14971	14949	14949
query12	165	108	107	107
query13	1556	528	392	392
query14	9350	6930	7561	6930
query15	282	226	193	193
query16	8408	653	476	476
query17	1633	756	586	586
query18	2072	420	311	311
query19	213	176	152	152
query20	126	125	121	121
query21	204	122	104	104
query22	4586	4529	4601	4529
query23	34369	33199	33716	33199
query24	6674	2382	2286	2286
query25	464	498	384	384
query26	818	286	159	159
query27	2118	491	342	342
query28	5535	2480	2482	2480
query29	649	597	465	465
query30	220	192	155	155
query31	965	920	842	842
query32	76	95	58	58
query33	490	370	296	296
query34	761	880	528	528
query35	827	853	819	819
query36	1034	1065	963	963
query37	116	101	81	81
query38	4269	4403	4330	4330
query39	1512	1480	1469	1469
query40	196	117	103	103
query41	51	56	54	54
query42	119	104	104	104
query43	504	539	499	499
query44	1363	857	833	833
query45	196	180	178	178
query46	903	1063	661	661
query47	1916	1947	1827	1827
query48	392	414	326	326
query49	719	491	405	405
query50	659	687	390	390
query51	7105	7003	6836	6836
query52	108	99	98	98
query53	236	260	191	191
query54	486	497	413	413
query55	89	81	81	81
query56	283	271	250	250
query57	1234	1201	1151	1151
query58	269	243	258	243
query59	3120	3155	3096	3096
query60	297	274	270	270
query61	120	115	117	115
query62	764	738	687	687
query63	229	192	195	192
query64	3251	1050	670	670
query65	3226	3144	3138	3138
query66	805	387	293	293
query67	16108	15751	15440	15440
query68	5368	830	522	522
query69	506	296	251	251
query70	1198	1163	1144	1144
query71	391	303	251	251
query72	6020	3824	3913	3824
query73	648	763	361	361
query74	10350	9224	9011	9011
query75	3209	3168	2663	2663
query76	3144	1173	781	781
query77	562	390	272	272
query78	10117	10060	9431	9431
query79	4137	783	579	579
query80	799	521	435	435
query81	520	273	238	238
query82	671	150	124	124
query83	194	168	165	165
query84	292	96	77	77
query85	733	404	317	317
query86	400	305	305	305
query87	4392	4531	4348	4348
query88	4696	2203	2167	2167
query89	415	332	296	296
query90	1774	192	188	188
query91	136	138	110	110
query92	66	59	52	52
query93	2696	858	531	531
query94	697	406	303	303
query95	332	277	257	257
query96	490	622	284	284
query97	2866	2874	2757	2757
query98	223	197	191	191
query99	1494	1402	1286	1286
Total cold run time: 290678 ms
Total hot run time: 194024 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.88 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ae17f748ded7cd397a769872c770cbee2ead8f2b, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.10
query5	0.42	0.41	0.41
query6	1.15	0.66	0.64
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.50	0.51
query10	0.55	0.56	0.56
query11	0.15	0.10	0.10
query12	0.13	0.12	0.11
query13	0.61	0.61	0.59
query14	2.72	2.75	2.75
query15	0.90	0.83	0.83
query16	0.39	0.38	0.38
query17	1.02	1.06	1.06
query18	0.22	0.20	0.20
query19	1.95	1.83	1.99
query20	0.02	0.01	0.01
query21	15.36	1.01	0.62
query22	0.76	0.86	0.68
query23	15.23	1.40	0.58
query24	3.19	1.32	0.96
query25	0.16	0.16	0.16
query26	0.40	0.15	0.14
query27	0.08	0.09	0.05
query28	13.75	0.97	0.43
query29	12.57	3.93	3.31
query30	0.26	0.09	0.07
query31	2.82	0.58	0.38
query32	3.22	0.55	0.47
query33	2.94	3.03	3.00
query34	16.66	5.25	4.51
query35	4.56	4.48	4.49
query36	0.66	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.96 s
Total hot run time: 30.88 s

@morrySnow morrySnow marked this pull request as ready for review January 17, 2025 03:15
924060929
924060929 previously approved these changes Jan 21, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 21, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow force-pushed the fix_cbo_rewrite_not_work branch from ae17f74 to 18ff746 Compare February 6, 2025 08:23
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor Author

run feut

@morrySnow morrySnow force-pushed the fix_cbo_rewrite_not_work branch from 18ff746 to 97170e5 Compare February 13, 2025 09:04
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31563 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 97170e548eb70f0eb89e917556933feabf00926d, data reload: false

------ Round 1 ----------------------------------
q1	17617	5201	5009	5009
q2	2045	306	172	172
q3	10395	1302	723	723
q4	10231	996	525	525
q5	7513	2352	2353	2352
q6	185	167	133	133
q7	889	751	613	613
q8	9288	1299	1028	1028
q9	4870	4742	4735	4735
q10	6825	2320	1905	1905
q11	479	288	264	264
q12	338	358	216	216
q13	17757	3691	3088	3088
q14	229	230	208	208
q15	499	464	463	463
q16	625	611	609	609
q17	558	856	347	347
q18	6683	6257	6199	6199
q19	1206	946	536	536
q20	322	322	193	193
q21	2805	2131	1935	1935
q22	366	338	310	310
Total cold run time: 101725 ms
Total hot run time: 31563 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5108	5096	5084	5084
q2	235	327	229	229
q3	2172	2647	2316	2316
q4	1411	1796	1360	1360
q5	4224	4131	4174	4131
q6	203	160	123	123
q7	1859	1819	1680	1680
q8	2607	2649	2579	2579
q9	7330	7088	7120	7088
q10	3006	3198	2732	2732
q11	565	522	482	482
q12	693	747	615	615
q13	3534	3933	3243	3243
q14	282	291	267	267
q15	525	471	475	471
q16	638	698	629	629
q17	1120	1675	1334	1334
q18	7542	7407	7331	7331
q19	772	789	840	789
q20	2052	2071	1881	1881
q21	5442	4985	4932	4932
q22	642	583	554	554
Total cold run time: 51962 ms
Total hot run time: 49850 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183014 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 97170e548eb70f0eb89e917556933feabf00926d, data reload: false

query1	969	372	397	372
query2	6518	1833	1798	1798
query3	6793	208	207	207
query4	26186	23623	23451	23451
query5	4309	634	472	472
query6	302	195	180	180
query7	4605	499	296	296
query8	305	248	227	227
query9	8619	2547	2583	2547
query10	480	317	253	253
query11	15429	15091	15005	15005
query12	157	108	107	107
query13	1682	522	404	404
query14	9206	6170	6153	6153
query15	206	195	192	192
query16	7523	652	471	471
query17	1218	708	564	564
query18	1967	401	307	307
query19	188	199	161	161
query20	121	113	115	113
query21	208	124	103	103
query22	4147	4425	4256	4256
query23	34077	32862	33143	32862
query24	7699	2394	2362	2362
query25	530	438	381	381
query26	1240	299	161	161
query27	2505	445	328	328
query28	4354	2399	2393	2393
query29	724	544	409	409
query30	234	191	159	159
query31	942	881	752	752
query32	76	67	64	64
query33	596	358	306	306
query34	807	807	513	513
query35	791	819	741	741
query36	978	969	864	864
query37	121	100	74	74
query38	4137	4249	3972	3972
query39	1458	1424	1396	1396
query40	222	115	100	100
query41	52	53	49	49
query42	120	101	104	101
query43	479	479	470	470
query44	1266	781	779	779
query45	172	176	159	159
query46	853	1048	633	633
query47	1749	1762	1706	1706
query48	375	398	290	290
query49	800	522	414	414
query50	654	719	415	415
query51	4184	4192	4196	4192
query52	112	109	95	95
query53	216	253	190	190
query54	468	473	410	410
query55	75	79	83	79
query56	263	263	271	263
query57	1110	1145	1062	1062
query58	233	228	249	228
query59	2692	2810	2781	2781
query60	288	269	284	269
query61	144	113	119	113
query62	806	730	651	651
query63	226	184	181	181
query64	4303	1000	652	652
query65	3233	3146	3131	3131
query66	1121	461	315	315
query67	15630	15426	15191	15191
query68	7848	755	508	508
query69	468	290	270	270
query70	1201	1123	1110	1110
query71	453	279	275	275
query72	5809	3539	3737	3539
query73	761	748	345	345
query74	8986	9099	8833	8833
query75	3304	3200	2677	2677
query76	3425	1175	724	724
query77	535	348	270	270
query78	9989	10092	9232	9232
query79	1807	815	582	582
query80	601	517	449	449
query81	513	270	242	242
query82	211	125	97	97
query83	179	168	160	160
query84	243	114	79	79
query85	750	344	324	324
query86	366	319	312	312
query87	4428	4715	4334	4334
query88	3471	2166	2150	2150
query89	378	326	281	281
query90	2019	189	195	189
query91	133	133	108	108
query92	74	58	55	55
query93	1900	993	578	578
query94	722	418	287	287
query95	352	266	254	254
query96	473	554	266	266
query97	2757	2876	2718	2718
query98	241	207	202	202
query99	1315	1406	1269	1269
Total cold run time: 269965 ms
Total hot run time: 183014 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 97170e548eb70f0eb89e917556933feabf00926d, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.08	0.06
query4	1.61	0.10	0.10
query5	0.44	0.42	0.40
query6	1.16	0.66	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.60	0.52	0.51
query10	0.58	0.60	0.57
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	2.80	2.70	2.81
query15	0.91	0.86	0.86
query16	0.38	0.38	0.38
query17	1.00	1.06	1.04
query18	0.22	0.20	0.20
query19	1.91	1.83	1.98
query20	0.01	0.02	0.01
query21	15.37	0.86	0.53
query22	0.75	1.09	0.64
query23	15.06	1.35	0.64
query24	9.09	2.79	0.44
query25	0.33	0.14	0.23
query26	0.88	0.19	0.14
query27	0.05	0.05	0.05
query28	6.48	0.80	0.43
query29	12.55	3.92	3.23
query30	0.26	0.08	0.07
query31	2.80	0.59	0.38
query32	3.22	0.54	0.47
query33	2.95	3.03	3.00
query34	15.78	5.24	4.53
query35	4.55	4.57	4.55
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.21 s
Total hot run time: 30.26 s

@morrySnow morrySnow force-pushed the fix_cbo_rewrite_not_work branch from 97170e5 to 2d4fe89 Compare May 22, 2025 08:12
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34109 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d4fe894322ef2704a9b4219e73ed9d6b2b17ac5, data reload: false

------ Round 1 ----------------------------------
q1	26361	5112	5022	5022
q2	2066	277	208	208
q3	10369	1256	708	708
q4	10228	1004	542	542
q5	7542	2368	2340	2340
q6	187	164	135	135
q7	926	743	610	610
q8	9330	1304	1183	1183
q9	6756	5196	5075	5075
q10	6879	2310	1893	1893
q11	488	293	283	283
q12	347	352	215	215
q13	17797	3649	3085	3085
q14	224	229	211	211
q15	525	486	495	486
q16	426	432	381	381
q17	617	873	372	372
q18	7797	7285	7168	7168
q19	1287	954	579	579
q20	336	331	232	232
q21	4275	3195	2412	2412
q22	1086	1039	969	969
Total cold run time: 115849 ms
Total hot run time: 34109 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5068	5073	5101	5073
q2	232	332	230	230
q3	2182	2613	2366	2366
q4	1326	1770	1320	1320
q5	4427	4380	4421	4380
q6	212	172	127	127
q7	2031	1945	1769	1769
q8	2589	2484	2454	2454
q9	7280	7231	7164	7164
q10	2942	3215	2724	2724
q11	565	521	505	505
q12	663	785	628	628
q13	3538	3914	3335	3335
q14	298	317	269	269
q15	524	480	469	469
q16	439	492	447	447
q17	1159	1611	1369	1369
q18	7747	7647	7392	7392
q19	830	882	965	882
q20	2016	1946	1832	1832
q21	4857	4551	4455	4455
q22	1075	1087	1030	1030
Total cold run time: 52000 ms
Total hot run time: 50220 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192332 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d4fe894322ef2704a9b4219e73ed9d6b2b17ac5, data reload: false

query1	1439	1088	1057	1057
query2	6199	1876	1891	1876
query3	11004	4497	4492	4492
query4	54234	25814	23075	23075
query5	5153	477	463	463
query6	376	221	199	199
query7	5045	484	277	277
query8	318	244	233	233
query9	6429	2635	2633	2633
query10	442	335	263	263
query11	15145	14925	14772	14772
query12	164	120	112	112
query13	1154	520	409	409
query14	10126	6459	6362	6362
query15	207	200	181	181
query16	7108	682	533	533
query17	1097	751	585	585
query18	1560	419	331	331
query19	208	192	178	178
query20	132	120	123	120
query21	214	128	112	112
query22	4472	4549	4422	4422
query23	34435	33514	33556	33514
query24	6770	2428	2424	2424
query25	460	470	411	411
query26	765	264	150	150
query27	2488	513	350	350
query28	3551	2187	2185	2185
query29	596	564	453	453
query30	280	227	191	191
query31	888	880	751	751
query32	96	61	68	61
query33	479	354	321	321
query34	785	855	564	564
query35	788	844	777	777
query36	961	1039	906	906
query37	116	104	78	78
query38	4269	4291	4289	4289
query39	1493	1441	1463	1441
query40	206	115	108	108
query41	55	60	51	51
query42	126	119	112	112
query43	523	514	497	497
query44	1377	846	845	845
query45	176	175	175	175
query46	840	1028	644	644
query47	1831	1885	1805	1805
query48	410	433	341	341
query49	685	512	445	445
query50	670	684	408	408
query51	4238	4208	4163	4163
query52	130	108	104	104
query53	232	258	182	182
query54	579	563	506	506
query55	86	88	83	83
query56	290	284	287	284
query57	1119	1137	1105	1105
query58	260	256	244	244
query59	2724	2818	2699	2699
query60	327	315	309	309
query61	127	125	127	125
query62	728	724	643	643
query63	222	183	183	183
query64	2064	985	661	661
query65	4298	4270	4232	4232
query66	762	394	309	309
query67	16151	15822	15414	15414
query68	7096	873	524	524
query69	542	326	267	267
query70	1235	1136	1123	1123
query71	505	333	289	289
query72	5774	4815	4984	4815
query73	1318	779	357	357
query74	9262	9147	8671	8671
query75	3811	3187	2686	2686
query76	4244	1196	744	744
query77	616	379	282	282
query78	10215	10275	9302	9302
query79	2143	813	577	577
query80	606	504	443	443
query81	483	265	218	218
query82	438	130	99	99
query83	251	247	247	247
query84	296	106	97	97
query85	784	349	303	303
query86	408	306	297	297
query87	4449	4424	4305	4305
query88	3297	2244	2232	2232
query89	419	337	281	281
query90	1779	210	202	202
query91	141	143	108	108
query92	72	60	59	59
query93	1757	953	578	578
query94	655	389	311	311
query95	369	297	279	279
query96	504	563	283	283
query97	2750	2798	2640	2640
query98	244	203	203	203
query99	1449	1416	1282	1282
Total cold run time: 300594 ms
Total hot run time: 192332 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d4fe894322ef2704a9b4219e73ed9d6b2b17ac5, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.26	0.19	0.19
query4	1.62	0.19	0.18
query5	0.42	0.43	0.44
query6	1.15	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.51
query10	0.57	0.58	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.78	0.80	0.85
query15	0.88	0.86	0.84
query16	0.38	0.39	0.38
query17	1.01	1.05	1.03
query18	0.23	0.21	0.20
query19	1.95	1.85	1.86
query20	0.02	0.01	0.01
query21	15.40	0.91	0.56
query22	0.74	1.25	0.66
query23	14.93	1.38	0.67
query24	7.02	1.54	0.86
query25	0.51	0.17	0.09
query26	0.53	0.17	0.15
query27	0.06	0.04	0.05
query28	9.13	0.92	0.45
query29	12.58	4.07	3.45
query30	0.26	0.10	0.06
query31	2.81	0.59	0.38
query32	3.23	0.54	0.46
query33	3.10	3.03	3.13
query34	15.74	5.06	4.47
query35	4.48	4.50	4.49
query36	0.69	0.50	0.48
query37	0.08	0.06	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.15	0.13
query41	0.07	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 102.68 s
Total hot run time: 29.26 s

@morrySnow morrySnow force-pushed the fix_cbo_rewrite_not_work branch from 2d4fe89 to f0da9b5 Compare May 22, 2025 10:17
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 22, 2025
@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33682 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f0da9b530af08c91a0c624aefc8358489a6d4732, data reload: false

------ Round 1 ----------------------------------
q1	26292	5012	5007	5007
q2	2067	276	181	181
q3	10416	1239	711	711
q4	10217	994	507	507
q5	7513	2408	2331	2331
q6	181	167	137	137
q7	905	746	618	618
q8	9327	1235	1028	1028
q9	6840	5109	5145	5109
q10	6819	2307	1861	1861
q11	481	289	265	265
q12	331	354	210	210
q13	17755	3640	3040	3040
q14	239	234	216	216
q15	535	485	485	485
q16	415	435	365	365
q17	588	845	374	374
q18	7520	7181	7164	7164
q19	1223	946	531	531
q20	348	350	211	211
q21	3931	2556	2349	2349
q22	1013	1006	982	982
Total cold run time: 114956 ms
Total hot run time: 33682 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5044	5024	5076	5024
q2	235	323	227	227
q3	2216	2681	2330	2330
q4	1346	1741	1383	1383
q5	4418	4428	4370	4370
q6	226	179	135	135
q7	1984	1886	1709	1709
q8	2608	2496	2525	2496
q9	7258	7155	7168	7155
q10	2967	3187	2780	2780
q11	597	517	494	494
q12	659	781	617	617
q13	3527	3883	3295	3295
q14	274	304	268	268
q15	530	481	489	481
q16	465	483	439	439
q17	1139	1504	1400	1400
q18	7680	7435	7413	7413
q19	790	807	833	807
q20	1997	2102	1936	1936
q21	4785	4287	4256	4256
q22	1063	1047	1014	1014
Total cold run time: 51808 ms
Total hot run time: 50029 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186406 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f0da9b530af08c91a0c624aefc8358489a6d4732, data reload: false

query1	1012	477	519	477
query2	6548	1894	1871	1871
query3	6767	226	222	222
query4	26711	23344	23535	23344
query5	4349	635	448	448
query6	290	223	185	185
query7	4625	481	290	290
query8	259	222	203	203
query9	8623	2617	2599	2599
query10	445	311	260	260
query11	15716	15538	14925	14925
query12	156	103	105	103
query13	1656	510	407	407
query14	9066	6099	6232	6099
query15	201	190	162	162
query16	7172	649	483	483
query17	1215	715	589	589
query18	1988	408	300	300
query19	196	189	170	170
query20	123	124	129	124
query21	213	133	112	112
query22	4135	4307	4102	4102
query23	33888	33268	33271	33268
query24	8480	2398	2414	2398
query25	557	486	413	413
query26	1246	283	157	157
query27	2724	508	345	345
query28	4355	2123	2100	2100
query29	770	530	418	418
query30	279	215	188	188
query31	936	889	726	726
query32	77	66	63	63
query33	550	355	310	310
query34	812	842	514	514
query35	770	867	721	721
query36	947	988	866	866
query37	109	102	78	78
query38	4166	4099	4090	4090
query39	1469	1440	1408	1408
query40	207	119	111	111
query41	58	57	58	57
query42	120	108	107	107
query43	493	507	446	446
query44	1316	809	819	809
query45	191	188	175	175
query46	859	1023	612	612
query47	1790	1798	1771	1771
query48	384	417	304	304
query49	754	491	400	400
query50	672	678	421	421
query51	4165	4148	4125	4125
query52	110	105	98	98
query53	224	253	187	187
query54	586	586	507	507
query55	84	91	90	90
query56	295	306	288	288
query57	1127	1161	1077	1077
query58	280	270	250	250
query59	2580	2692	2648	2648
query60	331	319	294	294
query61	145	124	127	124
query62	798	760	657	657
query63	212	195	181	181
query64	4362	992	662	662
query65	4268	4241	4259	4241
query66	1197	412	316	316
query67	15940	15490	15442	15442
query68	8949	881	527	527
query69	465	297	267	267
query70	1229	1122	1100	1100
query71	460	328	304	304
query72	5500	4805	4865	4805
query73	745	673	356	356
query74	9216	9005	9042	9005
query75	4193	3201	2703	2703
query76	3627	1196	755	755
query77	843	368	318	318
query78	10127	10094	9266	9266
query79	2768	811	596	596
query80	637	575	437	437
query81	464	254	217	217
query82	465	126	94	94
query83	282	255	228	228
query84	298	102	84	84
query85	774	347	314	314
query86	340	306	278	278
query87	4495	4435	4342	4342
query88	2901	2237	2271	2237
query89	423	305	281	281
query90	1952	206	204	204
query91	141	143	114	114
query92	75	62	60	60
query93	1915	958	588	588
query94	681	454	286	286
query95	371	284	283	283
query96	492	567	281	281
query97	2710	2788	2658	2658
query98	238	207	202	202
query99	1410	1406	1278	1278
Total cold run time: 276335 ms
Total hot run time: 186406 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.07 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f0da9b530af08c91a0c624aefc8358489a6d4732, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.10	0.11
query3	0.25	0.19	0.19
query4	1.59	0.20	0.19
query5	0.46	0.44	0.44
query6	1.16	0.68	0.65
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.51	0.53
query10	0.57	0.57	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	0.78	0.80	0.80
query15	0.88	0.86	0.85
query16	0.37	0.39	0.38
query17	1.05	1.04	1.03
query18	0.22	0.21	0.21
query19	1.96	1.79	1.86
query20	0.02	0.02	0.01
query21	15.40	0.88	0.53
query22	0.74	1.07	0.94
query23	14.74	1.36	0.64
query24	7.19	1.66	0.55
query25	0.50	0.13	0.12
query26	0.63	0.15	0.14
query27	0.05	0.05	0.05
query28	10.09	0.86	0.45
query29	12.53	3.95	3.29
query30	0.25	0.09	0.07
query31	2.82	0.60	0.40
query32	3.22	0.55	0.46
query33	3.07	3.04	3.07
query34	15.81	5.14	4.48
query35	4.54	4.50	4.48
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.14
query41	0.09	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.75 s
Total hot run time: 29.07 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 2528d33 into apache:master May 28, 2025
26 of 27 checks passed
@morrySnow morrySnow deleted the fix_cbo_rewrite_not_work branch May 28, 2025 10:04
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
### What problem does this PR solve?

Related PR: apache#33591

Problem Summary:

when CTEAnchoer not exists in plan, cost based rewrite job could not get
correct cost from applied cbo rewrite rule plan.
liutang123 pushed a commit to liutang123/doris that referenced this pull request Oct 11, 2025
### What problem does this PR solve?

Related PR: apache#33591

Problem Summary:

when CTEAnchoer not exists in plan, cost based rewrite job could not get
correct cost from applied cbo rewrite rule plan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants