[Feature] Add time_round builtin functions #4640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
#4619
Add time_round functions that provides
time_floor&time_ceilat each time unit.Fix two related bugs.
struct TimeIntervalto useint64_tinstead ofint32_t, in case when the second diff overflowTypes of changes
Checklist
Further comments
This change didn't match the style as
TIMESTAMPDIFF, which has some syntactic sugar on the time units in FE. I'm not much familiar with this implementation, so I'm going to figure it out and make up for the documentation then.