Skip to content

Conversation

@Astralidea
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Fix #4633
Fix #4634
Fix #4635

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

并且BITMAP列只能通过配套的bitmap_union_count、bitmap_union、bitmap_hash等函数进行查询或使用。

离线场景下使用BITMAP会影响导入速度,在数据量大的情况下查询速度会慢于HLL,并优于Count Distinct。
实时场景下BITMAP也不能做到完全的精确去重,通常误差小于千分之一。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么bitmap在实时场景下不能做到精确去重呢?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实时场景下的BITMAP,通常不会引入全局字典,因为当全局字典大了之后时延很大,实时的吞吐和时延都会明显下降。导致查询和更新全局字典的成本和时延很高,会极大降低实时导入的性能。
这块文档需要特别说明一下吗?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦,这个描述不太准确。bitmap这个类型本身是精确的。只是在“实时场景”下,用户导入的数据本身是不精确的。比如不使用全局字典,或者使用了 bitmap_hash() 等函数导致的误差,这些和bitmap本身的实现无关。这个需要说明下。

@morningman morningman added the kind/docs Categorizes issue or PR as related to documentation. label Oct 9, 2020
@morningman morningman self-assigned this Oct 9, 2020
@Astralidea
Copy link
Contributor Author

这个仓库又让我搞没了,换到另一个 #4712 吧,我改了一下描述,看看还有啥问题。

@Astralidea Astralidea closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VARCHAR文档错误 SQL手册中缺少BITMAP类型介绍 HLL文档描述错误

2 participants