Skip to content

[fix](cache) fix mtmv cache can not use test #46537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
924060929 merged 2 commits into from
Jan 7, 2025
Merged

[fix](cache) fix mtmv cache can not use test #46537

924060929 merged 2 commits into from
Jan 7, 2025

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Jan 7, 2025 •
edited
Loading

What problem does this PR solve?

fix mtmv can not use sql cache, introduced by #46443

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

924060929 commented Jan 7, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

doris-robot commented Jan 7, 2025

TPC-H: Total hot run time: 32732 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f09c4a239cfadcd8b9ffde254a206c5711cd0c30, data reload: false

------ Round 1 ----------------------------------
q1	17595	6124	6029	6029
q2	2048	306	164	164
q3	10416	1264	755	755
q4	10237	861	428	428
q5	8104	2167	1981	1981
q6	203	176	143	143
q7	890	744	595	595
q8	9245	1382	1207	1207
q9	5246	4915	4971	4915
q10	6730	2315	1836	1836
q11	496	282	256	256
q12	348	356	216	216
q13	17758	3709	3111	3111
q14	228	237	208	208
q15	567	506	501	501
q16	623	636	571	571
q17	585	869	330	330
q18	7004	6522	6461	6461
q19	2261	989	565	565
q20	307	313	188	188
q21	2831	2159	1968	1968
q22	364	330	304	304
Total cold run time: 104086 ms
Total hot run time: 32732 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6332	6204	6221	6204
q2	244	322	231	231
q3	2289	2656	2319	2319
q4	1442	1895	1410	1410
q5	4336	4752	4887	4752
q6	196	184	148	148
q7	2027	1959	1839	1839
q8	2716	2836	2693	2693
q9	7332	7307	7272	7272
q10	3120	3346	2788	2788
q11	566	508	486	486
q12	632	761	610	610
q13	3574	3862	3213	3213
q14	283	303	274	274
q15	577	505	508	505
q16	654	701	655	655
q17	1210	1740	1262	1262
q18	7664	7433	7393	7393
q19	883	1155	1129	1129
q20	2029	2046	1973	1973
q21	5673	5301	4826	4826
q22	611	625	593	593
Total cold run time: 54390 ms
Total hot run time: 52575 ms

@doris-robot
Copy link

doris-robot commented Jan 7, 2025

TPC-DS: Total hot run time: 197203 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f09c4a239cfadcd8b9ffde254a206c5711cd0c30, data reload: false

query1	1308	955	909	909
query2	6429	2248	2431	2248
query3	11078	4821	5074	4821
query4	32966	23477	23576	23477
query5	3878	616	480	480
query6	268	206	195	195
query7	3982	487	300	300
query8	302	261	243	243
query9	9254	2784	2772	2772
query10	457	316	266	266
query11	17873	15350	15638	15350
query12	159	111	105	105
query13	1705	532	435	435
query14	11085	6920	7391	6920
query15	240	199	190	190
query16	7749	634	446	446
query17	1559	786	610	610
query18	2108	418	356	356
query19	219	187	151	151
query20	127	122	114	114
query21	207	133	110	110
query22	4822	4520	4550	4520
query23	34622	33708	34122	33708
query24	6883	2311	2306	2306
query25	481	444	397	397
query26	732	274	157	157
query27	2166	457	339	339
query28	5624	2517	2484	2484
query29	522	556	414	414
query30	204	190	157	157
query31	977	911	827	827
query32	66	57	52	52
query33	507	349	324	324
query34	751	875	514	514
query35	807	831	785	785
query36	1022	1044	934	934
query37	116	96	73	73
query38	4381	4185	4219	4185
query39	1586	1485	1445	1445
query40	206	116	102	102
query41	48	45	49	45
query42	124	108	106	106
query43	514	527	486	486
query44	1401	827	838	827
query45	194	180	169	169
query46	876	1079	652	652
query47	2004	1997	1981	1981
query48	393	428	321	321
query49	722	488	387	387
query50	664	670	401	401
query51	7152	7106	7103	7103
query52	97	101	91	91
query53	228	260	203	203
query54	470	492	413	413
query55	79	77	84	77
query56	256	266	237	237
query57	1242	1207	1188	1188
query58	245	241	224	224
query59	3158	3391	3083	3083
query60	283	271	279	271
query61	107	102	106	102
query62	883	815	766	766
query63	225	195	199	195
query64	2953	1055	658	658
query65	3338	3412	3279	3279
query66	848	413	300	300
query67	16584	15803	15573	15573
query68	8353	695	525	525
query69	480	294	246	246
query70	1201	1154	1107	1107
query71	441	308	251	251
query72	6470	3882	3878	3878
query73	661	751	369	369
query74	10118	9307	9072	9072
query75	4464	3174	2670	2670
query76	4049	1192	768	768
query77	778	376	278	278
query78	10028	10032	9461	9461
query79	3406	792	582	582
query80	692	509	427	427
query81	469	276	226	226
query82	567	142	123	123
query83	189	156	144	144
query84	278	88	77	77
query85	756	443	298	298
query86	354	328	304	304
query87	4449	4391	4425	4391
query88	4272	2224	2207	2207
query89	409	330	295	295
query90	1837	184	189	184
query91	140	134	101	101
query92	64	119	52	52
query93	1683	860	532	532
query94	652	373	291	291
query95	334	262	254	254
query96	494	615	271	271
query97	2928	2986	2852	2852
query98	221	196	215	196
query99	1721	1544	1412	1412
Total cold run time: 297474 ms
Total hot run time: 197203 ms

@doris-robot
Copy link

doris-robot commented Jan 7, 2025

ClickBench: Total hot run time: 32.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f09c4a239cfadcd8b9ffde254a206c5711cd0c30, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.60	0.10	0.10
query5	0.42	0.42	0.40
query6	1.18	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.56	0.51	0.50
query10	0.56	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.82	2.72	2.75
query15	0.90	0.82	0.82
query16	0.39	0.38	0.39
query17	1.06	1.05	1.08
query18	0.23	0.21	0.20
query19	1.87	1.80	2.04
query20	0.01	0.01	0.01
query21	15.36	0.89	0.57
query22	0.76	0.78	0.63
query23	15.30	1.44	0.55
query24	2.93	1.92	1.99
query25	0.14	0.17	0.15
query26	0.33	0.15	0.13
query27	0.06	0.05	0.05
query28	14.39	1.44	1.04
query29	12.58	4.08	3.37
query30	0.24	0.09	0.07
query31	2.83	0.59	0.37
query32	3.23	0.53	0.46
query33	3.14	3.09	3.03
query34	16.79	5.09	4.50
query35	4.56	4.50	4.56
query36	0.65	0.50	0.48
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.7 s
Total hot run time: 32.3 s

@924060929 924060929 merged commit 1320116 into apache:master Jan 7, 2025
27 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 7, 2025
@924060929
[fix](cache) fix mtmv cache can not use test (#46537)
b05f34f 
fix mtmv can not use sql cache, introduced by #46443
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Merged
924060929 pushed a commit that referenced this pull request Jan 8, 2025
@github-actions
branch-3.0: [fix](cache) fix mtmv cache can not use test #46537 (#46555)
f52b44b 
fix mtmv can not use sql cache, introduced by #46443
@924060929 924060929 deleted the fix-mv-sql-cache branch January 8, 2025 04:55
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@924060929
[fix](cache) fix mtmv cache can not use test (#46537)
4f35c7d 
fix mtmv can not use sql cache, introduced by #46443
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
hello-stephen pushed a commit that referenced this pull request Jan 8, 2025
@github-actions @924060929
branch-2.1: [fix](cache) fix mtmv cache can not use test #46537 (#46607)
6a68b09 
Cherry-picked from #46537

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
csun5285 pushed a commit to csun5285/doris that referenced this pull request Mar 28, 2025
@morrySnow
[fix](nereids) fix sql cache bug and some tests apache#46443 apache#4…
900a7e6 
…6537 (apache#3821)

pick from apache doris' branch-3.0

- apache#46506
- apache#46555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@zddr zddr zddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@924060929 @hello-stephen @doris-robot @zddr @morrySnow