Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jan 8, 2025

pick #46347

…hen the including columns miss key columns on new schema (apache#46347)

During a schema change which changes key columns, partial update on
shadow index's tablet may cause duplicate key problem. So we abort the
partial update in this situation.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41143 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0a54978dc71c03c255872e4941a4ad62a11a8bb1, data reload: false

------ Round 1 ----------------------------------
q1	17564	7494	7288	7288
q2	2057	175	167	167
q3	10551	1170	1243	1170
q4	10224	805	712	712
q5	7734	2982	2962	2962
q6	258	152	149	149
q7	982	612	614	612
q8	9355	2038	2032	2032
q9	6725	6482	6459	6459
q10	7011	2287	2328	2287
q11	457	272	263	263
q12	414	215	214	214
q13	17799	2993	3020	2993
q14	236	212	213	212
q15	565	523	524	523
q16	683	615	623	615
q17	1006	611	568	568
q18	7541	6689	6642	6642
q19	1392	1121	995	995
q20	480	201	197	197
q21	4033	3489	3099	3099
q22	1096	984	1007	984
Total cold run time: 108163 ms
Total hot run time: 41143 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7306	7194	7372	7194
q2	330	231	219	219
q3	3004	3046	3044	3044
q4	2066	1830	1853	1830
q5	5704	5812	5769	5769
q6	221	139	142	139
q7	2222	1799	1835	1799
q8	3359	3561	3516	3516
q9	8896	8907	8891	8891
q10	3603	3540	3577	3540
q11	602	498	501	498
q12	810	577	605	577
q13	10372	3170	3136	3136
q14	290	268	295	268
q15	581	524	522	522
q16	702	689	675	675
q17	1825	1616	1605	1605
q18	8281	7859	7426	7426
q19	1730	1570	1546	1546
q20	2069	1790	1773	1773
q21	5284	5069	5185	5069
q22	1093	1002	1021	1002
Total cold run time: 70350 ms
Total hot run time: 60038 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190959 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0a54978dc71c03c255872e4941a4ad62a11a8bb1, data reload: false

query1	967	377	362	362
query2	6507	2137	2109	2109
query3	6710	223	221	221
query4	34081	23465	23360	23360
query5	4329	472	453	453
query6	275	166	175	166
query7	4617	316	312	312
query8	298	218	217	217
query9	9679	2675	2676	2675
query10	471	262	251	251
query11	18196	15330	15239	15239
query12	155	104	101	101
query13	1633	436	415	415
query14	9959	6545	7211	6545
query15	252	179	182	179
query16	8083	448	482	448
query17	1640	581	567	567
query18	2132	312	317	312
query19	247	169	153	153
query20	118	109	109	109
query21	215	103	108	103
query22	4591	4369	4157	4157
query23	35079	33752	33947	33752
query24	11227	2856	2874	2856
query25	671	422	405	405
query26	1274	177	173	173
query27	2511	347	354	347
query28	7744	2464	2432	2432
query29	898	446	450	446
query30	332	164	159	159
query31	1012	809	810	809
query32	100	58	55	55
query33	783	287	288	287
query34	963	496	532	496
query35	850	732	722	722
query36	1097	918	947	918
query37	132	71	73	71
query38	4018	3834	3842	3834
query39	1465	1417	1422	1417
query40	204	99	98	98
query41	51	50	47	47
query42	107	100	103	100
query43	528	504	496	496
query44	1269	831	821	821
query45	181	165	171	165
query46	1152	728	723	723
query47	1883	1810	1799	1799
query48	474	370	378	370
query49	1186	400	386	386
query50	823	407	414	407
query51	7278	7073	7096	7073
query52	105	93	88	88
query53	262	181	186	181
query54	1336	463	469	463
query55	78	80	75	75
query56	276	256	240	240
query57	1240	1081	1078	1078
query58	232	207	214	207
query59	3258	2928	2972	2928
query60	300	257	248	248
query61	113	110	106	106
query62	868	701	665	665
query63	222	191	193	191
query64	5351	660	663	660
query65	3257	3197	3176	3176
query66	1480	313	324	313
query67	16013	16088	15604	15604
query68	4766	579	584	579
query69	442	263	258	258
query70	1220	1118	1139	1118
query71	414	264	267	264
query72	6456	4034	4115	4034
query73	770	352	350	350
query74	10303	8992	8975	8975
query75	3446	2665	2625	2625
query76	2933	1012	1036	1012
query77	406	296	293	293
query78	10341	9580	9543	9543
query79	1053	605	600	600
query80	662	469	459	459
query81	510	242	249	242
query82	213	120	125	120
query83	176	175	150	150
query84	244	86	87	86
query85	1036	361	352	352
query86	332	314	312	312
query87	4548	4406	4200	4200
query88	3758	2414	2349	2349
query89	390	301	296	296
query90	1991	190	191	190
query91	182	150	150	150
query92	64	58	52	52
query93	1079	557	554	554
query94	825	313	287	287
query95	354	259	256	256
query96	615	286	295	286
query97	3314	3157	3143	3143
query98	217	203	205	203
query99	1532	1302	1280	1280
Total cold run time: 299430 ms
Total hot run time: 190959 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0a54978dc71c03c255872e4941a4ad62a11a8bb1, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.22	0.07	0.06
query4	1.63	0.10	0.11
query5	0.51	0.51	0.54
query6	1.14	0.74	0.72
query7	0.02	0.02	0.02
query8	0.03	0.03	0.03
query9	0.57	0.50	0.51
query10	0.55	0.54	0.57
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.60	0.59
query14	2.95	2.95	2.94
query15	0.90	0.83	0.84
query16	0.39	0.37	0.37
query17	1.07	1.06	1.05
query18	0.24	0.22	0.20
query19	2.00	1.79	2.01
query20	0.01	0.01	0.01
query21	15.38	0.61	0.60
query22	2.91	2.51	2.96
query23	17.02	0.95	0.85
query24	3.28	0.87	1.39
query25	0.36	0.16	0.07
query26	0.41	0.15	0.14
query27	0.05	0.03	0.05
query28	10.17	1.11	1.07
query29	12.60	3.27	3.24
query30	0.25	0.06	0.06
query31	2.85	0.40	0.38
query32	3.24	0.46	0.46
query33	3.00	2.99	3.06
query34	16.78	4.47	4.44
query35	4.46	4.55	4.53
query36	0.68	0.52	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.02	0.04
Total cold run time: 107.17 s
Total hot run time: 33.55 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 8, 2025

run feut

@dataroaring dataroaring merged commit d0568b8 into apache:branch-3.0 Jan 8, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants