Skip to content

branch-2.1: [fix] Add initialization list to the copy constructor of ScanPredicate in jni_connect.h #46666 #46725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 10, 2025
Merged

branch-2.1: [fix] Add initialization list to the copy constructor of ScanPredicate in jni_connect.h #46666 #46725

yiguolei merged 1 commit into from
Jan 10, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2025

Cherry-picked from #46666

@Tech-Circle-48
[fix] Add initialization list to the copy constructor of ScanPredicat…
34416bb 
…e in jni_connect.h (#46666)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
The copy constructor of `ScanPredicate` in `jni_connect.h` does not use
an initialization list, which might result in uninitialized member
variables or unintended behavior.
@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 9, 2025
@dataroaring dataroaring reopened this Jan 9, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jan 9, 2025

TeamCity be ut coverage result:
Function Coverage: 36.41% (9564/26266)
Line Coverage: 27.99% (79028/282364)
Region Coverage: 26.65% (40499/151977)
Branch Coverage: 23.40% (20524/87704)
Coverage Report: http://coverage.selectdb-in.cc/coverage/34416bb84278819507d308a6ca6d0bce6903b764_34416bb84278819507d308a6ca6d0bce6903b764/report/index.html

@yiguolei yiguolei merged commit 62ad145 into branch-2.1 Jan 10, 2025
18 of 19 checks passed
@github-actions github-actions bot deleted the auto-pick-46666-branch-2.1 branch January 10, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @yiguolei @dataroaring @Tech-Circle-48