Skip to content

Conversation

@ccoffline
Copy link
Contributor

@ccoffline ccoffline commented Sep 27, 2020

Proposed changes

#4581
fix hard Preconditions.checkState() by setting cardinality to -1 when computation is invalid.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

@ccoffline ccoffline changed the title fix hard cardinality check which makes the queries fail fix hard cardinality check which makes queries fail Sep 27, 2020
@ccoffline ccoffline changed the title fix hard cardinality check which makes queries fail [Bug] Fix hard cardinality check which makes queries fail Sep 27, 2020
@morningman morningman added area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug. labels Oct 4, 2020
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Oct 12, 2020
@morningman morningman merged commit c69fe23 into apache:master Oct 13, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] SelectNode.cardinality < 0 cause query exception "Unexpected exception: null"

2 participants