Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Sep 28, 2020

Proposed changes

fix delete on may not work in some cases, this is describe in #4682

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix [BUG] delete on in batch delete may not work  #4682), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yangzhg yangzhg changed the title Fix delete on may not work Fix delete on clause may not work in routineLoad Sep 28, 2020
@yangzhg yangzhg self-assigned this Sep 28, 2020
@morningman morningman added area/load Issues or PRs related to all kinds of load kind/fix Categorizes issue or PR as related to a bug. labels Sep 29, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Sep 29, 2020
@morningman morningman merged commit 0475aa9 into apache:master Sep 30, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] delete on in batch delete may not work

2 participants