Skip to content

[UI Part 5] Enable HTTP Server 2 by FE config #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 12 commits into from
Oct 13, 2020
Merged

[UI Part 5] Enable HTTP Server 2 by FE config #4684

morningman merged 12 commits into from
Oct 13, 2020

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Sep 28, 2020

Proposed changes

This is the last PR of proposal #4308

  1. Add a new FE config enable_http_server_v2 to enable new HTTP Server implementation. The default value is false.
  2. Add a new FE config http_api_extra_base_path so that we can set base path for Frontend UI.
  3. Refactor the new HTTP API response body. The return http status code is always 200, and using internal code in response body to indicate the certain error.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have create an issue on (Fix [Proposal][UI][HttpServer] FE frontend and backend separation #4308), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@morningman morningman added the area/fe/frontpage Issues or PRs related to the FE web page label Sep 28, 2020
@morningman morningman self-assigned this Sep 28, 2020
yangzhg
yangzhg previously approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman force-pushed the new_http_server branch 2 times, most recently from 61b0c00 to 0fb96f4 Compare October 9, 2020 16:01
@yangzhg yangzhg self-requested a review October 12, 2020 06:06
yangzhg
yangzhg approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Oct 12, 2020
@morningman morningman merged commit c934cf9 into apache:master Oct 13, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhg yangzhg yangzhg approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/fe/frontpage Issues or PRs related to the FE web page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Proposal][UI][HttpServer] FE frontend and backend separation

3 participants

@morningman @yangzhg @morningman-cmy