[fix](jdbc catalog) Change BE jdbc Driver loading to Java code #46912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
zy-kkk
force-pushed
the
jdbc_driver_load
branch
from
47f3f0d to
2feed87
Compare
morningman
reviewed
Feb 10, 2025
be/src/vec/exec/vjdbc_connector.cpp
Outdated
| std::string driver_path; | ||
|
|
||
| if (_conn_param.driver_path.find(":/") == std::string::npos) { | ||
| driver_path = "file://" + config::jdbc_drivers_dir + "/" + _conn_param.driver_path; |
Contributor
There was a problem hiding this comment.
Driver path maybe an absolute path like: /mnt/disk1/path/to/1.jar, how to handle it?
Member
Author
There was a problem hiding this comment.
I added a path check on the FE side. The Driver URL is always sent by FE to BE, so BE is only responsible for processing it.
zy-kkk
force-pushed
the
jdbc_driver_load
branch
from
2feed87 to
70a8f5b
Compare
Member
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
zy-kkk
changed the title
zy-kkk
changed the title
morningman
approved these changes
Feb 12, 2025
hubgeter
approved these changes
Feb 12, 2025
wuwenchi
approved these changes
Feb 12, 2025
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Feb 18, 2025
…e#46912) Related PR: apache#45806 Problem Summary: In the previous BE processing of JDBC Driver, the Driver jar will be downloaded to the local cache directory first, and the cached jar package will be provided to the JVM for loading. This will cause two problems 1. The jar package in the cache may fail to load due to duplication 2. Frequent repeated loading of the driver by the JVM will cause Compressed class space OOM In order to fix these two problems, this PR has the following changes 1. Remove the logic of BE downloading the Driver Jar to the local cache directory, and directly hand over the original path to Java's Classloader for processing 2. Treat the jar packages with the same name in the same path as one and cache them in the map to avoid repeated loading and cause Compressed class space OOM
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…e#46912) Related PR: apache#45806 Problem Summary: In the previous BE processing of JDBC Driver, the Driver jar will be downloaded to the local cache directory first, and the cached jar package will be provided to the JVM for loading. This will cause two problems 1. The jar package in the cache may fail to load due to duplication 2. Frequent repeated loading of the driver by the JVM will cause Compressed class space OOM In order to fix these two problems, this PR has the following changes 1. Remove the logic of BE downloading the Driver Jar to the local cache directory, and directly hand over the original path to Java's Classloader for processing 2. Treat the jar packages with the same name in the same path as one and cache them in the map to avoid repeated loading and cause Compressed class space OOM
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Feb 25, 2025
…e#46912) Related PR: apache#45806 Problem Summary: In the previous BE processing of JDBC Driver, the Driver jar will be downloaded to the local cache directory first, and the cached jar package will be provided to the JVM for loading. This will cause two problems 1. The jar package in the cache may fail to load due to duplication 2. Frequent repeated loading of the driver by the JVM will cause Compressed class space OOM In order to fix these two problems, this PR has the following changes 1. Remove the logic of BE downloading the Driver Jar to the local cache directory, and directly hand over the original path to Java's Classloader for processing 2. Treat the jar packages with the same name in the same path as one and cache them in the map to avoid repeated loading and cause Compressed class space OOM
dataroaring
pushed a commit
that referenced
this pull request
Feb 25, 2025
Closed
csun5285
pushed a commit
to csun5285/doris
that referenced
this pull request
Mar 28, 2025
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…e#46912) Related PR: apache#45806 Problem Summary: In the previous BE processing of JDBC Driver, the Driver jar will be downloaded to the local cache directory first, and the cached jar package will be provided to the JVM for loading. This will cause two problems 1. The jar package in the cache may fail to load due to duplication 2. Frequent repeated loading of the driver by the JVM will cause Compressed class space OOM In order to fix these two problems, this PR has the following changes 1. Remove the logic of BE downloading the Driver Jar to the local cache directory, and directly hand over the original path to Java's Classloader for processing 2. Treat the jar packages with the same name in the same path as one and cache them in the map to avoid repeated loading and cause Compressed class space OOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #45806
Problem Summary:
In the previous BE processing of JDBC Driver, the Driver jar will be downloaded to the local cache directory first, and the cached jar package will be provided to the JVM for loading. This will cause two problems
In order to fix these two problems, this PR has the following changes
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)