Skip to content

branch-2.1: [Fix](schema change) Fix NPE when rename column on table which has sequence type column #46906 #46942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 14, 2025
Merged

branch-2.1: [Fix](schema change) Fix NPE when rename column on table which has sequence type column #46906 #46942

yiguolei merged 1 commit into from
Jan 14, 2025

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jan 14, 2025

pick #46906

@bobhan1
[Fix](schema change) Fix NPE when rename column on table which has se…
fd55b17 
…quence type column (apache#46906)

### What problem does this PR solve?
Problem Summary:
```mysql
CREATE TABLE `tbl` (
  `c` tinyint NULL,
) ENGINE=OLAP
UNIQUE KEY(`c`)
DISTRIBUTED BY HASH(`c`) BUCKETS 10
PROPERTIES (
  "function_column.sequence_type" = "bigint"
);

mysql> alter table tbl rename column c c_bk;                                                         
ERROR 1105 (HY000): errCode = 2, detailMessage = Cannot invoke "String.equalsIgnoreCase(String)" because the return value of "org.apache.doris.catalog.OlapTable.getSequenceMapCol()" is null
```
@Thearas
Copy link
Contributor

Thearas commented Jan 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 14, 2025

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 14, 2025

run feut

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 14, 2025

run p0

@yiguolei yiguolei merged commit c606272 into apache:branch-2.1 Jan 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dev/2.1.8-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobhan1 @Thearas @yiguolei