Skip to content

[fix](memtable) do not reset arena in to_block() (#46988) #46989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaijchen wants to merge 1 commit into from
Closed

[fix](memtable) do not reset arena in to_block() (#46988) #46989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/olap/memtable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,8 +518,8 @@ Status MemTable::_to_block(std::unique_ptr<vectorized::Block>* res) {
RETURN_IF_ERROR(_sort_by_cluster_keys());
}
_input_mutable_block.clear();
// After to block, all data in arena is saved in the block
_arena.reset();
// DORIS-18080. Do not reset _arena here,
// because it is still used in ~MemTable() when releasing agg_places
*res = vectorized::Block::create_unique(_output_mutable_block.to_block());
return Status::OK();
}
Expand Down
Loading