Skip to content

[Bug](function) fix wrong result when case when have more than 256 conditions and the… #47179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 1 commit into from
Jan 24, 2025
Merged

[Bug](function) fix wrong result when case when have more than 256 conditions and the… #47179

BiteTheDDDDt merged 1 commit into from
Jan 24, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jan 17, 2025 •
edited
Loading

What problem does this PR solve?

fix wrong result when case when have more than 256 conditions and then column is not nullable

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jan 17, 2025

run buildall

@BiteTheDDDDt BiteTheDDDDt added dev/2.0.0 2.0.0 release dev/2.1.x dev/2.0.x and removed dev/2.0.0 2.0.0 release labels Jan 17, 2025
@wm1581066 wm1581066 added usercase Important user case type label dev/2.0.0 2.0.0 release and removed dev/2.0.x labels Jan 17, 2025
@BiteTheDDDDt BiteTheDDDDt added dev/2.0.x dev/3.0.x usercase Important user case type label and removed usercase Important user case type label dev/2.0.0 2.0.0 release labels Jan 17, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 4f3575a into apache:master Jan 24, 2025
36 of 38 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result when case when have more than 256 co…
7af5ddd 
…nditions and the… (#47179)

### What problem does this PR solve?
fix wrong result when case when have more than 256 conditions and then
column is not nullable
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result when case when have more than 256 co…
2477349 
…nditions and the… (#47179)

### What problem does this PR solve?
fix wrong result when case when have more than 256 conditions and then
column is not nullable
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Merged
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jan 24, 2025
@BiteTheDDDDt
[Bug](function) fix wrong result when case when have more than 256 co…
0aa76f9 
…nditions and the… (apache#47179)

### What problem does this PR solve?
fix wrong result when case when have more than 256 conditions and then
column is not nullable
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jan 24, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 25, 2025
@github-actions @BiteTheDDDDt
branch-2.1: [Bug](function) fix wrong result when case when have more…
2ae03d7 
… than 256 conditions and the… #47179 (#47392)

Cherry-picked from #47179

Co-authored-by: Pxl <xl@selectdb.com>
dataroaring pushed a commit that referenced this pull request Jan 26, 2025
@github-actions @BiteTheDDDDt
branch-3.0: [Bug](function) fix wrong result when case when have more…
e4eaf13 
… than 256 conditions and the… #47179 (#47391)

Cherry-picked from #47179

Co-authored-by: Pxl <xl@selectdb.com>
BiteTheDDDDt added a commit that referenced this pull request Feb 14, 2025
@BiteTheDDDDt
branch-2.0: [Bug](function) fix wrong result when case when have more…
557edd3 
… than 256 conditions and the… #47179 (#47395)

Cherry-picked from #47179
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@BiteTheDDDDt @lzyy2024
[Bug](function) fix wrong result when case when have more than 256 co…
2df8cf0 
…nditions and the… (apache#47179)

### What problem does this PR solve?
fix wrong result when case when have more than 256 conditions and then
column is not nullable
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@Mryange Mryange mentioned this pull request Mar 6, 2025
Closed
16 tasks
@yiguolei yiguolei mentioned this pull request Mar 25, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt @koarz
[Bug](function) fix wrong result when case when have more than 256 co…
e3828ac 
…nditions and the… (apache#47179)

### What problem does this PR solve?
fix wrong result when case when have more than 256 conditions and then
column is not nullable
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.16-merged dev/2.1.9-merged dev/3.0.4-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BiteTheDDDDt @Thearas @zclllyybb @zhangstar333 @yiguolei @wm1581066 @dataroaring