Skip to content

branch-3.0: [feature](function)support url domain functions #42488 #47188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Feb 27, 2025
Merged

branch-3.0: [feature](function)support url domain functions #42488 #47188

dataroaring merged 1 commit into from
Feb 27, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 17, 2025

Cherry-picked from #42488

@github-actions github-actions bot requested a review from dataroaring as a code owner January 17, 2025 12:57
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 17, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 17, 2025

run buildall

1 similar comment
@zhangstar333
Copy link
Contributor

zhangstar333 commented Jan 20, 2025

run buildall

@zhangstar333 @dataroaring
[feature](function)support url domain functions (#42488)
13628ab 
## Proposed changes

support
top_level_domain/first_significant_subdomain/cut_to_first_significant_subdomain
functions
doc: apache/doris-website#1230

<!--Describe your changes.-->
@dataroaring dataroaring force-pushed the auto-pick-42488-branch-3.0 branch from bc1e46c to 13628ab Compare February 25, 2025 11:54
@dataroaring
Copy link
Contributor

dataroaring commented Feb 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 25, 2025

TeamCity cloud ut coverage result:
Function Coverage: 82.23% (1060/1289)
Line Coverage: 65.74% (17585/26751)
Region Coverage: 65.28% (8661/13267)
Branch Coverage: 55.23% (4671/8458)
Coverage Report: http://coverage.selectdb-in.cc/coverage/13628abad1a6aaa9f5cd80ab36e29df839a6af24_13628abad1a6aaa9f5cd80ab36e29df839a6af24_cloud/report/index.html

dataroaring
dataroaring approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ae90c3c into branch-3.0 Feb 27, 2025
24 of 29 checks passed
@github-actions github-actions bot deleted the auto-pick-42488-branch-3.0 branch February 27, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @zhangstar333 @dataroaring @doris-robot