Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Jan 20, 2025

What problem does this PR solve?

pick #46959

Related PR: #46959

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.

Add a 600 seconds timeout for updating tablet stat.

  • Does this need documentation?
    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xy720 xy720 changed the title [branch2.1](bug) Fix dead lock in Tablet Stat Mgr branch-2.1:[fix](bug) Fix dead lock in Tablet Stat Mgr Jan 20, 2025
@xy720 xy720 changed the title branch-2.1:[fix](bug) Fix dead lock in Tablet Stat Mgr branch-2.1: [fix](bug) Fix dead lock in Tablet Stat Mgr Jan 20, 2025
@xy720
Copy link
Member Author

xy720 commented Jan 20, 2025

run buildall

@xy720 xy720 requested a review from yiguolei January 20, 2025 12:01
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 21, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@lide-reed lide-reed merged commit fe182c7 into apache:branch-2.1 Jan 21, 2025
22 of 23 checks passed
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
fix dead lock in Tablet Stat Mgr, which will cause the rowcount out of date. the join reorder strongly depend on rowcount, so the dead lock will cause performance degradation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants