Skip to content

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Feb 5, 2025

What problem does this PR solve?

Issue Number: DORIS-18129

Problem Summary:

  1. Remove stack trace when "unknown load_id".
  2. Suggest user to retry the load when this error occurs.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Member Author

kaijchen commented Feb 5, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32472 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a8b4656812075065621d01b630c84be3c3017cb5, data reload: false

------ Round 1 ----------------------------------
q1	17615	5565	5406	5406
q2	2052	310	172	172
q3	10426	1288	725	725
q4	10219	971	534	534
q5	7526	2439	2174	2174
q6	198	172	136	136
q7	910	753	612	612
q8	9233	1386	1158	1158
q9	5244	4958	4943	4943
q10	6846	2328	1889	1889
q11	483	276	272	272
q12	344	360	215	215
q13	17758	3704	3158	3158
q14	222	233	215	215
q15	537	477	460	460
q16	632	613	587	587
q17	578	873	323	323
q18	7017	6577	6436	6436
q19	1209	967	552	552
q20	308	329	201	201
q21	2837	2246	1994	1994
q22	370	340	310	310
Total cold run time: 102564 ms
Total hot run time: 32472 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5917	5525	5512	5512
q2	242	332	232	232
q3	2259	2633	2297	2297
q4	1404	1833	1407	1407
q5	4308	4715	4666	4666
q6	174	164	127	127
q7	2087	2005	1869	1869
q8	2688	2810	2667	2667
q9	7457	7249	7205	7205
q10	2959	3288	2769	2769
q11	599	530	510	510
q12	678	770	646	646
q13	3501	3937	3316	3316
q14	276	317	271	271
q15	532	483	465	465
q16	664	680	655	655
q17	1227	1744	1255	1255
q18	7776	7488	7280	7280
q19	858	1177	1047	1047
q20	2002	2031	1895	1895
q21	5735	5264	4934	4934
q22	608	583	565	565
Total cold run time: 53951 ms
Total hot run time: 51590 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184428 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a8b4656812075065621d01b630c84be3c3017cb5, data reload: false

query1	973	397	385	385
query2	6520	2113	2053	2053
query3	6795	220	222	220
query4	33303	23225	22972	22972
query5	4365	635	470	470
query6	312	199	188	188
query7	4605	485	310	310
query8	309	250	236	236
query9	9474	2656	2655	2655
query10	475	314	253	253
query11	18068	15091	14999	14999
query12	158	111	106	106
query13	1647	523	388	388
query14	10728	6504	7540	6504
query15	214	196	184	184
query16	7697	600	456	456
query17	1603	730	548	548
query18	1935	398	290	290
query19	216	185	169	169
query20	113	109	108	108
query21	210	123	101	101
query22	4237	4291	4014	4014
query23	33764	32848	33011	32848
query24	6410	2231	2270	2231
query25	497	440	383	383
query26	1202	271	150	150
query27	2000	464	325	325
query28	5133	2460	2419	2419
query29	658	562	416	416
query30	229	198	156	156
query31	932	879	794	794
query32	74	69	58	58
query33	513	355	298	298
query34	758	861	524	524
query35	778	802	733	733
query36	1008	1005	924	924
query37	120	104	80	80
query38	4320	4338	4143	4143
query39	1469	1450	1404	1404
query40	218	114	105	105
query41	61	56	60	56
query42	123	110	107	107
query43	517	535	512	512
query44	1323	825	810	810
query45	187	175	171	171
query46	857	1046	638	638
query47	1799	1860	1755	1755
query48	397	419	320	320
query49	813	511	443	443
query50	634	664	407	407
query51	4200	4202	4116	4116
query52	110	104	95	95
query53	232	260	183	183
query54	488	509	413	413
query55	83	78	82	78
query56	263	265	245	245
query57	1149	1146	1080	1080
query58	251	235	241	235
query59	3003	3067	2882	2882
query60	271	270	282	270
query61	123	122	123	122
query62	818	703	638	638
query63	216	194	187	187
query64	4160	1064	663	663
query65	3242	3163	3127	3127
query66	1044	415	312	312
query67	15938	15636	15413	15413
query68	2459	834	554	554
query69	408	296	265	265
query70	1219	1144	1149	1144
query71	323	299	259	259
query72	6032	3897	4177	3897
query73	638	745	360	360
query74	9591	8974	8830	8830
query75	3147	3154	2681	2681
query76	2228	1181	800	800
query77	334	369	282	282
query78	10038	10043	9402	9402
query79	986	894	603	603
query80	1217	551	446	446
query81	530	274	248	248
query82	1177	155	132	132
query83	284	182	160	160
query84	232	102	76	76
query85	840	381	304	304
query86	423	321	314	314
query87	4497	4481	4367	4367
query88	3130	2208	2152	2152
query89	398	335	292	292
query90	1714	196	198	196
query91	138	139	108	108
query92	60	58	54	54
query93	945	894	531	531
query94	617	408	311	311
query95	346	264	252	252
query96	502	624	284	284
query97	2777	2851	2788	2788
query98	221	218	201	201
query99	1317	1481	1257	1257
Total cold run time: 275110 ms
Total hot run time: 184428 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.98 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8b4656812075065621d01b630c84be3c3017cb5, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.61	0.11	0.11
query5	0.42	0.42	0.42
query6	1.13	0.67	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.60	0.50	0.49
query10	0.57	0.55	0.55
query11	0.16	0.09	0.10
query12	0.15	0.11	0.12
query13	0.62	0.62	0.61
query14	2.72	2.75	2.75
query15	0.92	0.82	0.82
query16	0.38	0.40	0.36
query17	1.01	1.07	1.07
query18	0.23	0.21	0.21
query19	1.97	1.87	1.98
query20	0.02	0.01	0.02
query21	15.36	0.95	0.58
query22	0.76	0.73	0.72
query23	15.31	1.45	0.59
query24	3.01	2.08	0.98
query25	0.22	0.18	0.06
query26	0.22	0.16	0.13
query27	0.06	0.06	0.04
query28	14.34	1.01	0.44
query29	12.60	3.99	3.30
query30	0.26	0.09	0.06
query31	2.82	0.61	0.39
query32	3.23	0.55	0.46
query33	3.02	3.01	3.06
query34	16.81	5.17	4.59
query35	4.58	4.58	4.54
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.65 s
Total hot run time: 30.98 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.09% (11004/26142)
Line Coverage: 32.37% (92901/287031)
Region Coverage: 31.51% (47627/151142)
Branch Coverage: 27.54% (24105/87534)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a8b4656812075065621d01b630c84be3c3017cb5_a8b4656812075065621d01b630c84be3c3017cb5/report/index.html

dataroaring
dataroaring previously approved these changes Feb 10, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 10, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 26, 2025
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01
Copy link
Contributor

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.80% (11941/26655)
Line Coverage 34.23% (99936/291939)
Region Coverage 33.38% (51136/153201)
Branch Coverage 28.91% (25664/88766)

@kaijchen
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31753 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 58ab28bba5f534e37fcc54d6e81a73266a3966ce, data reload: false

------ Round 1 ----------------------------------
q1	17564	5209	5199	5199
q2	2048	306	180	180
q3	10652	1244	766	766
q4	10248	1038	539	539
q5	7881	2371	2317	2317
q6	190	165	138	138
q7	917	777	619	619
q8	9310	1287	1049	1049
q9	5019	4728	4775	4728
q10	6848	2310	1894	1894
q11	472	298	263	263
q12	348	362	230	230
q13	17772	3698	3083	3083
q14	235	220	214	214
q15	537	458	466	458
q16	653	620	616	616
q17	590	860	343	343
q18	6683	6171	6092	6092
q19	1463	979	555	555
q20	316	320	204	204
q21	2911	2253	1958	1958
q22	382	343	308	308
Total cold run time: 103039 ms
Total hot run time: 31753 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5287	5265	5117	5117
q2	238	333	236	236
q3	2294	2830	2487	2487
q4	1504	1881	1424	1424
q5	4256	4117	4158	4117
q6	218	165	124	124
q7	1897	1852	1761	1761
q8	2596	2629	2622	2622
q9	7310	7174	7142	7142
q10	3038	3247	2782	2782
q11	571	511	483	483
q12	691	831	608	608
q13	3443	3967	3324	3324
q14	273	284	289	284
q15	523	469	464	464
q16	689	691	632	632
q17	1172	1611	1368	1368
q18	7617	7432	7269	7269
q19	818	976	962	962
q20	2031	2015	1901	1901
q21	5471	4947	4753	4753
q22	643	640	560	560
Total cold run time: 52580 ms
Total hot run time: 50420 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190955 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 58ab28bba5f534e37fcc54d6e81a73266a3966ce, data reload: false

query1	1340	985	922	922
query2	6205	1897	1927	1897
query3	11157	4610	4557	4557
query4	55059	25112	22921	22921
query5	5111	529	475	475
query6	357	205	190	190
query7	5020	498	289	289
query8	325	262	233	233
query9	6229	2597	2627	2597
query10	417	314	249	249
query11	15303	15145	14829	14829
query12	156	109	105	105
query13	1126	516	379	379
query14	10295	7239	6840	6840
query15	198	189	172	172
query16	7085	675	507	507
query17	1067	706	574	574
query18	1513	413	306	306
query19	198	191	163	163
query20	139	129	128	128
query21	212	123	110	110
query22	4613	4577	4301	4301
query23	33834	33347	33270	33270
query24	5729	2467	2464	2464
query25	494	456	416	416
query26	673	287	152	152
query27	1689	505	328	328
query28	2797	2462	2452	2452
query29	581	557	416	416
query30	212	191	162	162
query31	912	859	832	832
query32	75	69	60	60
query33	447	385	303	303
query34	777	864	495	495
query35	793	848	770	770
query36	934	1006	933	933
query37	125	101	79	79
query38	4404	4319	4089	4089
query39	1483	1454	1464	1454
query40	205	126	107	107
query41	58	58	55	55
query42	126	106	113	106
query43	507	523	484	484
query44	1329	831	806	806
query45	187	174	169	169
query46	884	1090	689	689
query47	1837	1842	1779	1779
query48	402	442	322	322
query49	733	563	445	445
query50	757	799	430	430
query51	4289	4256	4332	4256
query52	112	106	96	96
query53	241	261	202	202
query54	498	497	416	416
query55	84	80	79	79
query56	281	266	283	266
query57	1155	1161	1109	1109
query58	249	262	233	233
query59	2827	2897	2845	2845
query60	298	317	285	285
query61	123	116	123	116
query62	732	747	699	699
query63	232	190	191	190
query64	1455	1050	677	677
query65	3356	3216	3205	3205
query66	712	399	297	297
query67	15929	15560	15308	15308
query68	7257	828	497	497
query69	545	300	259	259
query70	1214	1133	1109	1109
query71	486	294	272	272
query72	5896	3750	3822	3750
query73	1371	771	356	356
query74	9158	9276	8790	8790
query75	3718	3152	2730	2730
query76	4328	1180	772	772
query77	620	366	287	287
query78	9994	10075	9306	9306
query79	3407	838	583	583
query80	715	552	466	466
query81	516	280	239	239
query82	693	127	132	127
query83	307	175	154	154
query84	295	89	74	74
query85	811	361	331	331
query86	408	304	311	304
query87	4429	4469	4376	4376
query88	3557	2230	2224	2224
query89	419	321	289	289
query90	1810	197	194	194
query91	142	143	111	111
query92	72	60	62	60
query93	2116	1085	568	568
query94	662	426	308	308
query95	368	275	265	265
query96	495	586	277	277
query97	3381	3440	3326	3326
query98	228	207	208	207
query99	1392	1403	1254	1254
Total cold run time: 299492 ms
Total hot run time: 190955 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 58ab28bba5f534e37fcc54d6e81a73266a3966ce, data reload: false

query1	0.03	0.03	0.04
query2	0.06	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.55	0.55	0.55
query6	1.17	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.56	0.53
query10	0.56	0.58	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.60	0.58
query14	2.67	2.70	2.69
query15	0.91	0.86	0.85
query16	0.39	0.37	0.37
query17	1.04	1.03	1.03
query18	0.21	0.20	0.20
query19	1.87	1.85	1.96
query20	0.01	0.01	0.01
query21	15.36	0.91	0.52
query22	0.75	1.10	0.73
query23	15.00	1.36	0.66
query24	6.54	1.78	1.42
query25	0.52	0.27	0.14
query26	0.60	0.16	0.13
query27	0.05	0.05	0.05
query28	10.24	0.83	0.42
query29	12.53	3.97	3.27
query30	0.25	0.09	0.06
query31	2.82	0.58	0.38
query32	3.22	0.57	0.47
query33	3.03	3.04	3.05
query34	15.76	5.16	4.53
query35	4.54	4.51	4.56
query36	0.68	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.09	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.26 s
Total hot run time: 31.58 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.98% (11994/26666)
Line Coverage 34.47% (100751/292276)
Region Coverage 33.66% (51615/153361)
Branch Coverage 29.41% (26109/88768)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 220d00f into apache:master Mar 4, 2025
24 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
Issue Number: DORIS-18129

Problem Summary:

1. Remove stack trace when "unknown load_id".
2. Suggest user to retry the load when this error occurs.
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
Issue Number: DORIS-18129

Problem Summary:

1. Remove stack trace when "unknown load_id".
2. Suggest user to retry the load when this error occurs.
yiguolei pushed a commit that referenced this pull request Mar 5, 2025
…47509 (#48639)

Cherry-picked from #47509

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
dataroaring pushed a commit that referenced this pull request Mar 10, 2025
…47509 (#48638)

Cherry-picked from #47509

Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Issue Number: DORIS-18129

Problem Summary:

1. Remove stack trace when "unknown load_id".
2. Suggest user to retry the load when this error occurs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants