Skip to content

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Feb 5, 2025

What problem does this PR solve?

A fix for #47150

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wangbo
Copy link
Contributor Author

wangbo commented Feb 5, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31999 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 29773ecdd09aee62225447e42610aa4776ca61b5, data reload: false

------ Round 1 ----------------------------------
q1	17595	5549	5329	5329
q2	2041	305	170	170
q3	10486	1274	702	702
q4	10245	962	516	516
q5	8493	2388	2146	2146
q6	203	169	131	131
q7	874	739	610	610
q8	9224	1344	1149	1149
q9	5978	4905	4900	4900
q10	6899	2338	1892	1892
q11	481	281	260	260
q12	344	372	208	208
q13	17765	3722	3068	3068
q14	233	230	201	201
q15	513	452	461	452
q16	639	619	584	584
q17	562	859	317	317
q18	7214	6406	6388	6388
q19	1955	958	538	538
q20	305	323	185	185
q21	2779	2111	1936	1936
q22	363	334	317	317
Total cold run time: 105191 ms
Total hot run time: 31999 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5581	5528	5511	5511
q2	232	325	233	233
q3	2233	2573	2282	2282
q4	1414	1880	1370	1370
q5	4276	4772	4636	4636
q6	180	168	130	130
q7	2107	1927	1827	1827
q8	2661	2781	2643	2643
q9	7251	7220	7224	7220
q10	2937	3267	2781	2781
q11	572	506	485	485
q12	663	744	611	611
q13	3414	4021	3313	3313
q14	269	296	265	265
q15	518	469	473	469
q16	642	667	658	658
q17	1236	1736	1239	1239
q18	7767	7661	7313	7313
q19	760	931	1095	931
q20	2018	2000	1890	1890
q21	5721	5205	4918	4918
q22	595	593	572	572
Total cold run time: 53047 ms
Total hot run time: 51297 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 183951 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 29773ecdd09aee62225447e42610aa4776ca61b5, data reload: false

query1	965	384	368	368
query2	6532	2045	2002	2002
query3	6790	216	221	216
query4	33291	23247	23019	23019
query5	4347	613	431	431
query6	284	189	181	181
query7	4614	486	312	312
query8	301	241	230	230
query9	9635	2661	2656	2656
query10	484	319	252	252
query11	17819	15043	14943	14943
query12	155	106	99	99
query13	1647	531	396	396
query14	9514	6470	6907	6470
query15	223	192	192	192
query16	7165	641	434	434
query17	1585	718	545	545
query18	1881	375	294	294
query19	194	174	150	150
query20	113	108	117	108
query21	199	121	101	101
query22	4058	4231	4206	4206
query23	34670	33060	33058	33058
query24	6766	2250	2256	2250
query25	490	468	425	425
query26	1070	226	159	159
query27	2289	466	327	327
query28	5516	2465	2450	2450
query29	560	537	438	438
query30	237	190	158	158
query31	961	881	808	808
query32	110	61	66	61
query33	532	369	309	309
query34	758	865	506	506
query35	796	808	745	745
query36	1007	1004	965	965
query37	121	97	84	84
query38	4117	4086	4029	4029
query39	1453	1391	1410	1391
query40	208	127	110	110
query41	58	55	55	55
query42	120	147	104	104
query43	508	514	473	473
query44	1352	785	792	785
query45	175	171	163	163
query46	848	1046	642	642
query47	1790	1808	1742	1742
query48	378	405	321	321
query49	771	481	385	385
query50	616	655	394	394
query51	4185	4174	4061	4061
query52	112	104	91	91
query53	226	249	181	181
query54	476	489	411	411
query55	78	77	77	77
query56	258	258	232	232
query57	1122	1169	1073	1073
query58	263	236	236	236
query59	2972	3023	2856	2856
query60	280	260	259	259
query61	117	117	115	115
query62	783	721	666	666
query63	219	188	185	185
query64	4651	1022	657	657
query65	3279	3179	3156	3156
query66	1082	413	303	303
query67	15970	15478	15329	15329
query68	5602	811	530	530
query69	467	294	260	260
query70	1195	1146	1122	1122
query71	392	280	258	258
query72	5817	3861	3788	3788
query73	647	762	356	356
query74	10102	8842	8879	8842
query75	3140	3180	2657	2657
query76	3227	1144	751	751
query77	471	372	280	280
query78	10088	10134	9369	9369
query79	2253	830	612	612
query80	704	505	440	440
query81	516	275	237	237
query82	208	155	123	123
query83	173	179	147	147
query84	239	93	78	78
query85	800	349	295	295
query86	401	318	258	258
query87	4451	4381	4281	4281
query88	3958	2179	2163	2163
query89	385	336	295	295
query90	1955	191	192	191
query91	128	135	105	105
query92	70	58	54	54
query93	2148	873	537	537
query94	663	400	301	301
query95	342	260	253	253
query96	480	612	279	279
query97	2756	2821	2777	2777
query98	219	205	200	200
query99	1267	1355	1282	1282
Total cold run time: 281410 ms
Total hot run time: 183951 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 29773ecdd09aee62225447e42610aa4776ca61b5, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.06
query4	1.62	0.11	0.11
query5	0.44	0.42	0.41
query6	1.14	0.67	0.64
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.59	0.51	0.49
query10	0.55	0.57	0.55
query11	0.15	0.10	0.10
query12	0.15	0.11	0.11
query13	0.60	0.59	0.59
query14	2.74	2.76	2.72
query15	0.89	0.81	0.82
query16	0.38	0.39	0.38
query17	1.01	1.03	1.05
query18	0.23	0.20	0.20
query19	1.82	1.98	1.80
query20	0.01	0.01	0.01
query21	15.35	0.92	0.56
query22	0.76	0.74	0.72
query23	15.28	1.46	0.51
query24	3.22	1.46	0.99
query25	0.29	0.09	0.16
query26	0.20	0.13	0.13
query27	0.05	0.04	0.05
query28	13.91	0.97	0.43
query29	12.53	3.91	3.25
query30	0.25	0.09	0.06
query31	2.82	0.61	0.40
query32	3.23	0.54	0.46
query33	2.97	3.06	3.05
query34	16.61	5.17	4.59
query35	4.52	4.49	4.54
query36	0.64	0.50	0.50
query37	0.09	0.06	0.05
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.14	0.12
query41	0.08	0.04	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.84 s
Total hot run time: 30.67 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.10% (11014/26161)
Line Coverage: 32.38% (92977/287144)
Region Coverage: 31.52% (47668/151207)
Branch Coverage: 27.53% (24111/87570)
Coverage Report: http://coverage.selectdb-in.cc/coverage/29773ecdd09aee62225447e42610aa4776ca61b5_29773ecdd09aee62225447e42610aa4776ca61b5/report/index.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR approved by anyone and no changes requested.

@wangbo wangbo merged commit df9eda8 into apache:master Feb 6, 2025
27 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
yiguolei pushed a commit that referenced this pull request Feb 6, 2025
Cherry-picked from #47523

Co-authored-by: wangbo <wangbo@selectdb.com>
dataroaring pushed a commit that referenced this pull request Feb 6, 2025
Cherry-picked from #47523

Co-authored-by: wangbo <wangbo@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
hubgeter pushed a commit to hubgeter/doris that referenced this pull request Mar 12, 2025
@yiguolei yiguolei mentioned this pull request Mar 25, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.4-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants