[branch-2.1](FoldFE) pick special date arithmetics of #37376 and #37766 #47616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#37376) Issue Number: close #xxx Java doesn't support the calculation of `0000-01-01`(0000 year is 1 B.C. which ISO-8601 defines). so some of our calc was wrong in FE. now fixed them. new result: ```sql mysql> select week('0000-01-01', 0),week('0000-01-01', 1),week('0000-01-01', 2),week('0000-01-01', 3),week('0000-01-01', 4), week('0000-01-01', 5), week('0000-01-01', 6), week('0000-01-01', 7); +------+------+------+------+------+------+------+------+ | 1 | 0 | 1 | 52 | 1 | 0 | 1 | 52 | +------+------+------+------+------+------+------+------+ | 1 | 0 | 1 | 52 | 1 | 0 | 1 | 52 | +------+------+------+------+------+------+------+------+ 1 row in set (0.10 sec) mysql> select week('0000-01-02', 0),week('0000-01-02', 1),week('0000-01-02', 2),week('0000-01-02', 3),week('0000-01-02', 4), week('0000-01-02', 5), week('0000-01-02', 6), week('0000-01-02', 7); +------+------+------+------+------+------+------+------+ | 1 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 1 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ 1 row in set (0.10 sec) ``` same with `yearweek`
…pache#37766) make `dayofyear`, `dayofweek`, `weekofyear` result of FE folding constant result same with MySQL. mainly about date in BC01 (year `0000`) before: ```sql mysql> select DAYOFWEEK('0000-01-01'),DAYOFWEEK('0000-01-02'),DAYOFWEEK('0000-01-03'),DAYOFWEEK('0000-01-04'),DAYOFWEEK('0000-01-05'),DAYOFWEEK('0000-01-06'),DAYOFWEEK('0000-01-07'),DAYOFWEEK('0000-01-08'); +------+------+------+------+------+------+------+------+ | 7 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +------+------+------+------+------+------+------+------+ | 7 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | +------+------+------+------+------+------+------+------+ mysql> select DAYOFYEAR('0000-02-27'),DAYOFYEAR('0000-02-28'),DAYOFYEAR('0000-03-01'),DAYOFYEAR('0000-03-02'); +------+------+------+------+ | 58 | 59 | 61 | 62 | +------+------+------+------+ | 58 | 59 | 61 | 62 | +------+------+------+------+ mysql> select WEEKOFYEAR('0000-01-01'),WEEKOFYEAR('0000-01-02'),WEEKOFYEAR('0000-01-03'),WEEKOFYEAR('0000-01-04'),WEEKOFYEAR('0000-01-05'),WEEKOFYEAR('0000-01-06'),WEEKOFYEAR('0000-01-07'),WEEKOFYEAR('0000-01-08'); +------+------+------+------+------+------+------+------+ | 52 | 52 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 52 | 52 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ mysql> select WEEKOFYEAR('0000-02-25'),WEEKOFYEAR('0000-02-26'),WEEKOFYEAR('0000-02-27'),WEEKOFYEAR('0000-02-28'),WEEKOFYEAR('0000-03-01'),WEEKOFYEAR('0000-03-02'),WEEKOFYEAR('2022-03-03'); +------+------+------+------+------+------+------+ | 8 | 8 | 8 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ | 8 | 8 | 8 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ ``` after: ```sql mysql> select DAYOFWEEK('0000-01-01'),DAYOFWEEK('0000-01-02'),DAYOFWEEK('0000-01-03'),DAYOFWEEK('0000-01-04'),DAYOFWEEK('0000-01-05'),DAYOFWEEK('0000-01-06'),DAYOFWEEK('0000-01-07'),DAYOFWEEK('0000-01-08'); +------+------+------+------+------+------+------+------+ | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 1 | +------+------+------+------+------+------+------+------+ | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 1 | +------+------+------+------+------+------+------+------+ mysql> select DAYOFYEAR('0000-02-27'),DAYOFYEAR('0000-02-28'),DAYOFYEAR('0000-03-01'),DAYOFYEAR('0000-03-02'); +------+------+------+------+ | 58 | 59 | 60 | 61 | +------+------+------+------+ | 58 | 59 | 60 | 61 | +------+------+------+------+ mysql> select WEEKOFYEAR('0000-01-01'),WEEKOFYEAR('0000-01-02'),WEEKOFYEAR('0000-01-03'),WEEKOFYEAR('0000-01-04'),WEEKOFYEAR('0000-01-05'),WEEKOFYEAR('0000-01-06'),WEEKOFYEAR('0000-01-07'),WEEKOFYEAR('0000-01-08'); +------+------+------+------+------+------+------+------+ | 52 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ | 52 | 1 | 1 | 1 | 1 | 1 | 1 | 1 | +------+------+------+------+------+------+------+------+ mysql> select WEEKOFYEAR('0000-02-25'),WEEKOFYEAR('0000-02-26'),WEEKOFYEAR('0000-02-27'),WEEKOFYEAR('0000-02-28'),WEEKOFYEAR('0000-03-01'),WEEKOFYEAR('0000-03-02'),WEEKOFYEAR('2022-03-03'); +------+------+------+------+------+------+------+ | 8 | 8 | 9 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ | 8 | 8 | 9 | 9 | 9 | 9 | 9 | +------+------+------+------+------+------+------+ ```
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #37376 and #37766