[Improve](cloud) support caching SchemaCloudDictionary in BE side #47629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldenmoon
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
/* * SchemaCloudDictionaryCache provides a local cache for SchemaCloudDictionary. * * Caching logic: * - If the dictionary associated with a given key has not had any new columns added * (determined by comparing the serialized data for consistency), * the cached dictionary is directly used to update the dictionary list in the rowset meta * (similar to the process_dictionary logic in write_schema_dict). * - If new columns have been detected, the local cache is disregarded, and the updated * dictionary should be fetched via the meta service. */ use SchemaCloudDictionaryCache in Backend to reduce the frequency of reading and converting SchemaCloudDictionary in MetaService
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31815 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 183512 ms |
ClickBench: Total hot run time: 31.15 s |
|
TeamCity cloud ut coverage result: |
Member
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31923 ms |
TPC-DS: Total hot run time: 183835 ms |
ClickBench: Total hot run time: 30.11 s |
|
TeamCity be ut coverage result: |
gavinchou
reviewed
Feb 20, 2025
Member
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31949 ms |
TPC-DS: Total hot run time: 191544 ms |
ClickBench: Total hot run time: 31.33 s |
Member
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32377 ms |
TPC-DS: Total hot run time: 183916 ms |
ClickBench: Total hot run time: 31.29 s |
gavinchou
approved these changes
Feb 27, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Feb 28, 2025
…7629) The most important changes focus on adding support for schema dictionary caching, modifying existing methods to utilize the cache, and ensuring schema consistency. ``` /* * SchemaCloudDictionaryCache provides a local cache for SchemaCloudDictionary. * * Caching logic: * - If the dictionary associated with a given key has not had any new columns added * (determined by comparing the serialized data for consistency), * the cached dictionary is directly used to update the dictionary list in the rowset meta * (similar to the process_dictionary logic in write_schema_dict). * - If new columns have been detected, the local cache is disregarded, and the updated * dictionary should be fetched via the meta service. */ ``` use SchemaCloudDictionaryCache in Backend to reduce the frequency of reading and converting SchemaCloudDictionary in MetaService
mymeiyi
pushed a commit
to mymeiyi/doris
that referenced
this pull request
Mar 4, 2025
…ache#47629) The most important changes focus on adding support for schema dictionary caching, modifying existing methods to utilize the cache, and ensuring schema consistency. ``` /* * SchemaCloudDictionaryCache provides a local cache for SchemaCloudDictionary. * * Caching logic: * - If the dictionary associated with a given key has not had any new columns added * (determined by comparing the serialized data for consistency), * the cached dictionary is directly used to update the dictionary list in the rowset meta * (similar to the process_dictionary logic in write_schema_dict). * - If new columns have been detected, the local cache is disregarded, and the updated * dictionary should be fetched via the meta service. */ ``` use SchemaCloudDictionaryCache in Backend to reduce the frequency of reading and converting SchemaCloudDictionary in MetaService
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ache#47629) The most important changes focus on adding support for schema dictionary caching, modifying existing methods to utilize the cache, and ensuring schema consistency. ``` /* * SchemaCloudDictionaryCache provides a local cache for SchemaCloudDictionary. * * Caching logic: * - If the dictionary associated with a given key has not had any new columns added * (determined by comparing the serialized data for consistency), * the cached dictionary is directly used to update the dictionary list in the rowset meta * (similar to the process_dictionary logic in write_schema_dict). * - If new columns have been detected, the local cache is disregarded, and the updated * dictionary should be fetched via the meta service. */ ``` use SchemaCloudDictionaryCache in Backend to reduce the frequency of reading and converting SchemaCloudDictionary in MetaService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important changes focus on adding support for schema dictionary caching, modifying existing methods to utilize the cache, and ensuring schema consistency.
use SchemaCloudDictionaryCache in Backend to reduce the frequency of reading and converting SchemaCloudDictionary in MetaService
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)