-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Make some debug log settings configurable and change some log level from info to debug to avoid performance bottlenecks #4766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rom info to debug to escape performance bottlenecks
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
Show resolved
Hide resolved
Are you sure the log is the FE performance bottlenecks? did you do any test or benchmark? |
the heavy work is still stream load and tablet schedule in fe, but log in FrontendServiceImpl make thing worse when cpu load is higher, we found that all stream load request failed when qps is higher because all threads(the limit is 4096) in fe blocked in db lock or log lock, and cannot process any request. just like the issue(#4765) mentioned. and I test the log performance in local machine with 8 logic core. it cost about 149388ms, every log cost about 0.075ms. Maybe the title is not accurate description for this PR. |
|
@caiconghui I see. Thank you. |
kangkaisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Proposed changes
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...