-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[InvertedIndex](Variant) support inverted index for array type in variant #47688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests. Improvements to inverted index support:
Addition of regression tests:
|
TPC-H: Total hot run time: 31645 ms |
TPC-DS: Total hot run time: 189993 ms |
ClickBench: Total hot run time: 30.53 s |
b48b36e to
291c359
Compare
|
run buildall |
TPC-H: Total hot run time: 31490 ms |
TPC-DS: Total hot run time: 183100 ms |
ClickBench: Total hot run time: 30.67 s |
|
TeamCity be ut coverage result: |
regression-test/suites/variant_p0/with_index/test_array_contains_with_inverted_index.groovy
Outdated
Show resolved
Hide resolved
regression-test/suites/variant_p0/with_index/test_array_contains_with_inverted_index.groovy
Show resolved
Hide resolved
291c359 to
fced830
Compare
fced830 to
a51cba9
Compare
|
run buildall |
TPC-H: Total hot run time: 31734 ms |
|
run buildall |
TPC-H: Total hot run time: 31685 ms |
TPC-DS: Total hot run time: 184758 ms |
ClickBench: Total hot run time: 30.47 s |
|
TeamCity be ut coverage result: |
airborne12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xiaokang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…iant (#47688) This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests
…iant (apache#47688) This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests
…iant (apache#47688) This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests
…iant (apache#47688) This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests
…iant (apache#47688) This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests
…iant (apache#47688) This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests
What problem does this PR solve?
This pull request includes several changes to support inverted indexes for arrays and improve the handling of complex data types in the codebase. The most important changes include modifications to the inverted index writer, updates to expression evaluation, and the addition of new regression tests.
Improvements to inverted index support:
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp: Updatedcheck_support_inverted_indexmethod to support one-level arrays and removed the check for extracted columns.be/src/vec/exprs/vexpr.cpp: Modified_evaluate_inverted_indexmethod to remove nullable types from the target type during evaluation.Addition of regression tests:
regression-test/data/variant_p0/with_index/test_array_inverted_index_profile.out: Added new test cases for array inverted index profiles.regression-test/suites/variant_p0/with_index/test_array_contains_with_inverted_index.groovy: Introduced a new test suite to validate thearray_containsfunction with inverted indexes.regression-test/suites/variant_p0/with_index/test_array_index_write.groovy: Added tests to verify writing to tables with array inverted indexes and handling various data types.Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)